Font Library: use resolvable domain in test #54763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbenedetto
added
[Type] Automated Testing
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/tests/fonts/font-library/wpRestFontLibraryController/getFontCollection.php |
mikachan
added
the
Backport to Gutenberg RC
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: 4225a35 |
mikachan
pushed a commit
that referenced
this pull request
Sep 25, 2023
mikachan
removed
the
Backport to Gutenberg RC
youknowriad
added
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix test than can break in different test envs depending the URL of the test env run.
Why?
To validate the URL of a font collection we have a function that calls
wp_http_validate_url()function.Because wp_http_validate_url() function uses the PHP native function
gethostbyname()function that is not being mocked. We just mock the URL request to fetch the data. If the domain of the url used can't be resolved or the url of the test env is not localhost, the url likehttps://localhost/examplecan be evaluated as invalid.How?
To fix this problem easily we can use a resolvable domain as
wordpress.orgin the test instead oflocalhost.Testing Instructions
Run PHP unit tests and check if they are running ok.