-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Face: backport from Core changeset 56500 #54218
Conversation
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.4/fonts/font-face/class-wp-font-face-resolver.php ❔ lib/compat/wordpress-6.4/fonts/font-face/class-wp-font-face.php ❔ lib/compat/wordpress-6.4/fonts/fonts.php ❔ phpunit/tests/fonts/font-face/base.php ❔ phpunit/tests/fonts/font-face/wpFontFace/generateAndPrint.php ❔ phpunit/tests/fonts/font-face/wpFontFaceResolver/getFontsFromThemeJson.php ❔ phpunit/tests/fonts/font-face/wpPrintFontFaces.php |
d773cef
to
15c0058
Compare
69acdab
to
2c3c729
Compare
2c3c729
to
eef352f
Compare
Flaky tests detected in 877d725. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6114287700
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed these changes, and they seem to be in line with what's already committed to Core.
I did a quick test and didn't notice any errors.
Therefore, I approve this PR.
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
What?
Font Face was merged into Core by changeset 56500. This PR backports the changes from Core.
Why?
To keep Core and Gutenberg files in synchronized.
How?
@core-merge
notes where appropriate.Review notes:
When comparing the changes from Core's changeset 56500, please note that it included the static instance in
wp_print_font_faces()
. This static was removed in Gutenberg via commit 98b331e and in Core via changeset 56540.Tip: Compare the changes from the code that's in Core's
trunk
, i.e. to avoid confusion of the static change.