Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak border control button to proper metrics and simpler action #53998

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Tweak border control button to proper metrics and simpler action #53998

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90d4b39
Fix button styles to updated metrics
richtabor Aug 28, 2023
19ee104
Simplify button text
richtabor Aug 28, 2023
b2b882f
Update CHANGELOG.md
richtabor Aug 28, 2023
544178b
Use proper border top color
richtabor Aug 28, 2023
cdadb2a
Fix tests
richtabor Sep 11, 2023
e899781
Merge branch 'trunk' into try/border-control-tweak
richtabor Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<!-- Learn how to maintain this file at https://github.com/WordPress/gutenberg/tree/HEAD/packages#maintaining-changelogs. -->

## Unreleased
- `BorderControl`: Apply proper metrics and simpler text ([#53998](https://github.com/WordPress/gutenberg/pull/53998)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG entries should all go under a sub-section — ie. Enhancements, Bug fix, etc

We can tweak this in following PRs (eg. #54394)


### Enhancements

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/border-control/border-control-dropdown/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ const BorderControlDropdown = (
onClose();
} }
>
{ __( 'Reset to default' ) }
{ __( 'Reset' ) }
</Button>
</DropdownContentWrapper>
) }
Expand Down
12 changes: 6 additions & 6 deletions packages/components/src/border-control/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,10 @@ export const resetButton = css`

/* Override button component styling */
&& {
border-top: ${ CONFIG.borderWidth } solid ${ COLORS.gray[ 200 ] };
border-top: ${ CONFIG.borderWidth } solid ${ COLORS.gray[ 400 ] };
border-top-left-radius: 0;
border-top-right-radius: 0;
height: 46px;
height: 40px;
}
`;

Expand All @@ -180,10 +180,10 @@ export const borderControlStylePicker = css`

export const borderStyleButton = css`
Copy link
Contributor

@ciampo ciampo Sep 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried using the size="compact" prop on the Button component, instead of adding style overrrdes? That should render a 32x32 button

&&&&& {
min-width: 30px;
width: 30px;
height: 30px;
padding: 3px;
min-width: 32px;
width: 32px;
height: 32px;
padding: 4px;
}
`;

Expand Down