Fix wp-scripts watch mode failing when block.json contains malformed JSON
#51971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormed JSON from stopping watch mode
fabiankaegy
added
[Type] Bug
fabiankaegy
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
Size Change: -2 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Aug 7, 2023
gziolo
reviewed
Aug 7, 2023
Co-authored-by: Greg Ziółkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixing the watch mode of
@wordpress/scriptsto no longer abort when it encounters malformed JSON.Why?
Currently the
watchmode of the@wordpress/scriptspackage fails whenever you either add a new emptyblock.jsonfile, or save it with malformed JSON in it.How?
Wrapping the
JSON.parsefunction call in atry catchblockTesting Instructions
@wordpress/scriptsin a project