Lodash: Refactor away from _.kebabCase() in block editor
#51687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
gziolo,
swissspidy,
flootr,
chad1008,
ntsekouras and
fabiankaegy
|
Size Change: -429 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
The PHP version of this method It's essential that both methods generate exact strings. |
Great point - thanks @Mamaduka! We were definitely missing to cover some of those scenarios, but I've updated the PR to cover them and borrowed all the tests you linked to in 2deb924. Let me know what you think! |
Mamaduka
approved these changes
Jun 20, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…#51687) * Block Editor: Introduce kebabCase util * Block Editor: Introduce unit tests for kebabCase() * Block Editor: Replace _.kebabCase() with our custom util * Block Editor: Update kebabCase() to handle other types * Cover all _wp_to_kebab_case() scenarios * Minor formatting fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.kebabCase()from the block editor package. This basically gets rid of half of the remainingkebabCase()usages in the entire codebase.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495We're pretty close with the migration away from Lodash, only 3 methods are used and we're close to reaping the benefits of not relying on it at all.
How?
We're introducing a custom
kebabCase()utility that basically customizes the existingparamCase()function from thechange-casepackage that we've already been utilizing throughout Gutenberg.The custom utility is necessary in order to keep backward compatibility with the Lodash function within the block editor context (it's mostly about properly handling class names the same way as Lodash's
kebabCase()did).We're adding unit tests to ensure we're covering all scenarios as Lodash did.
We're finally replacing all usages within the block editor package with the new utility function.
Testing Instructions