Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page details: Fix displaying slugs with non-latin characters #51679

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Page details: Fix displaying slugs with non-latin characters #51679

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
007e493
Page details: Fix displaying slug with non-latin characters
carolinan Jun 20, 2023
a58045d
Use utils from the WordPress url package
carolinan Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen-page/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ export default function SidebarNavigationScreenPage() {
className="edit-site-sidebar-navigation-screen__page-link"
href={ record.link }
>
{ record.link.replace( /^(https?:\/\/)?/, '' ) }
{ decodeURI(
record.link.replace( /^(https?:\/\/)?/, '' )
) }
Copy link
Member

@Mamaduka Mamaduka Jun 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the core uses the safeDecodeURIComponent from the url package, in other places for similar fixes. We can also replace the regex here with filterURLForDisplay.

{ filterURLForDisplay( safeDecodeURIComponent( record.link ) ) }

Edit: I found my PR that fixes a similar bug in post editor - #42930.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I did not know these existed.

</ExternalLink>
}
content={
Expand Down
6 changes: 5 additions & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen-page/page-details.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ function getPageDetails( page ) {
},
{
label: __( 'Slug' ),
value: <Truncate numberOfLines={ 1 }>{ page.slug }</Truncate>,
value: (
<Truncate numberOfLines={ 1 }>
{ decodeURI( page.slug ) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, but just safeDecodeURIComponent.

</Truncate>
),
},
];

Expand Down