Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try Site Editor panel metrics #51599

Closed
wants to merge 6 commits into from
Closed

Try Site Editor panel metrics #51599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c124ab6
Tweaks for SE metrics
richtabor Jun 16, 2023
8817006
Tweak for menu
richtabor Jun 16, 2023
8f8c6d6
Align panel title with site title
jameskoster Jun 20, 2023
dfbcf4f
Adjust padding when no icon is present
jameskoster Jun 20, 2023
7433434
has-icon
jameskoster Jun 20, 2023
72dd4ff
Merge branch 'trunk' into try/site-editor-metrics
richtabor Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/layout/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
}

@include break-medium {
width: calc(#{$nav-sidebar-width} - #{$canvas-padding});
width: calc(#{$nav-sidebar-width} - #{$canvas-padding * 0.75});
}

.edit-site-layout.is-full-canvas & {
Expand Down
4 changes: 2 additions & 2 deletions packages/edit-site/src/components/resizable-frame/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,11 +175,11 @@ function ResizableFrame( {
const resizeHandleVariants = {
default: {
opacity: 1,
left: -16,
left: -12,
},
resizing: {
opacity: 1,
left: -16,
left: -12,
scaleY: 1.3,
},
};
Expand Down
6 changes: 4 additions & 2 deletions packages/edit-site/src/components/sidebar-navigation-item/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
.edit-site-sidebar-navigation-item.components-item {
color: $gray-600;
// 6px right padding to align with + button
padding: $grid-unit-10 6px $grid-unit-10 $grid-unit-20;
border: none;
min-height: $grid-unit-50;
border-radius: $radius-block-ui;
Expand All @@ -18,6 +16,10 @@
color: $white;
}

&:not(.has-icon) {
padding-left: $grid-unit-20;
}

.edit-site-sidebar-navigation-item__drilldown-indicator {
fill: $gray-700;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen-navigation-menus/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.edit-site-sidebar-navigation-screen__description {
margin: 0 0 $grid-unit-40 0;
margin: 0 $grid-unit-50 $grid-unit-40 0;
}

.edit-site-sidebar-navigation-screen-navigation-menus__content {
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-navigation-screen/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export default function SidebarNavigationScreen( {
justify="flex-start"
>
<HStack
spacing={ 4 }
spacing={ 3 }
alignment="flex-start"
className="edit-site-sidebar-navigation-screen__title-icon"
>
Expand Down
5 changes: 5 additions & 0 deletions packages/edit-site/src/components/sidebar-navigation-screen/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
.components-heading {
margin-bottom: $grid-unit-10;
}

.edit-site-sidebar-navigation-screen-navigation-menus__content {
margin-left: -$grid-unit-20;
}
}

.edit-site-sidebar-navigation-screen__meta {
Expand Down Expand Up @@ -58,6 +62,7 @@
padding-top: $grid-unit-60 + $header-height;
margin-bottom: $grid-unit-10;
padding-bottom: $grid-unit-10;
padding-right: $grid-unit-10;
z-index: z-index(".edit-site-sidebar-navigation-screen__title-icon");
}

Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@

.edit-site-sidebar__content > div {
// This matches the logo padding
padding: 0 $grid-unit-15;
padding: 0 0 0 $grid-unit-15;
}
1 change: 0 additions & 1 deletion packages/edit-site/src/components/site-hub/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
}

.edit-site-site-hub__site-title {
margin-left: $grid-unit-05;
flex-grow: 1;
color: $gray-200;
}
Expand Down