Edit Site: Optimize loading useSelect call
#50546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jarda Snajdr <[email protected]>
tyxla
added
[Type] Performance
|
Size Change: -4 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
jsnajdr
approved these changes
May 12, 2023
There was a problem hiding this comment.
Looks good 👍
If we wanted to optimize even more, we could note that even after loaded becomes true, we still keep the subscription to coreStore and execute the useSelect callback on each change, although we are guaranteed to never need it.
We could do this:
const [ loaded, setLoaded ] = useState( false );
const registry = useRegistry();
useEffect( () => {
if ( loaded ) {
return;
}
let timer;
let prevInPause = false;
const unsub = registry.subscribe( () => {
const nextInPause = ! registry.select( coreStore ).hasResolvingSelectors();
if ( ! prevInPause && nextInPause ) {
clearTimeout( timer );
timer = setTimeout( () => setLoaded( true ), 1000 );
}
prevInPause = nextInPause;
} );
return () => {
unsub();
clearTimeout( timer );
};
}, [ loaded ] );This way the subscription exists only during the time before loaded becomes true.
We don't have to do this now, but it will be a good idea when we discover we have hundreds of idle store subscriptions in the editor that only call dummy callbacks and do nothing. Then it's time to start refactoring to this pattern.
|
Thanks, @jsnajdr. I wonder if we should handle those at a framework level somehow; it feels like a burden if the |
There are ways how to abstract away most of the effect code. There is a proposal in #41169 for a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is a follow-up to #50511 (comment) which optimizes the
useSelectcall of the site editor loading experience.Why?
Reduces the number of re-renders, as explained in the comment.
How?
We're only calling's
useSelectwhenloadedisfalse, once the site editor is marked as loaded,useSelectwill no longer trigger rerenders.Testing Instructions
Same as testing instructions of #50222.
Testing Instructions for Keyboard
None
Screenshots or screencast
None