Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ImagePlaceholder available via the global wp object #5039

Merged
merged 3 commits into from
Feb 19, 2018
Merged

Make ImagePlaceholder available via the global wp object #5039

merged 3 commits into from
Feb 19, 2018

Conversation

johnwatkins0
Copy link
Member

Description

I noticed the ImagePlaceHolder component was missing from the global wp object. I assume this is not a deliberate choice, as ImagePlaceHolder is super useful. This PR fixes the issue by importing and exporting it in blocks/index.js.

blocks/index.js Outdated
@@ -22,6 +22,7 @@ export { default as BlockEdit } from './block-edit';
export { default as BlockIcon } from './block-icon';
export { default as ColorPalette } from './color-palette';
export { default as Editable } from './rich-text/editable';
export { default as ImagePlaceHolder } from './image-placeholder';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the naming of the directory, I'd expect this to be camel-cased as: ImagePlaceholder

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, @aduth. The most recent commit changes ImagePlaceHolder to ImagePlaceholder (everywhere).

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@aduth aduth merged commit 967d010 into WordPress:master Feb 19, 2018
@mtias
Copy link
Member

mtias commented Mar 1, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants