Rich text: rename index.js > index.ts for type-only exports #50212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- renames rich-text/src/index.js to rich-text/src/index.ts so that it can export the type as a type
|
Size Change: -12 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Co-authored-by: Marin Atanasov <[email protected]>
|
Thanks so much for this! I must not have caught it because the warnings didn’t cause an error in CI, and I was relying on tsc for local verification :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, why and how?
When compiling the project, Webpack was whining at me:
"Enough!" I said, and I muted it by renaming index.js > index.ts and exporting
RichTextValueas a type.Related reading:
I don't know if this is the best way to go about it. 🤷 Checking with @noahtallen from #49651
Testing Instructions
Run
npm run devYou shouldn't see the following error in your console output.