Columns Block: Prevent removal of locked columns from the column count change UI #49530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +172 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
t-hamano
changed the title
|
Flaky tests detected in 91921bb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4593470947
|
andrewserong
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Nice work, thanks for following up on this detail @t-hamano and for adding the e2e coverage! This is testing well for me:
✅ Min, max, and the slider all work as-is when no locked blocks are present
✅ When a locked column block is present, its index is used to determine the minimum count, and the slider for column count works as expected 👍
LGTM! ✨
Co-authored-by: Andrew Serong <[email protected]>
|
Thanks for the review, @andrewserong! |
kevin940726
reviewed
Apr 9, 2023
| ); | ||
|
|
||
| // The min attribute should take into account locked columns | ||
| await expect( columnsChangeInput ).toHaveAttribute( 'min', '3' ); |
There was a problem hiding this comment.
@kevin940726
Thank you for noticing!
I was able to reproduce the same error locally as on GitHub Action. I fixed it in #49676 and it appears to be fixed locally. I will run the test several times on GitHub.
bph
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up based on this comment in #48691
What?
This PR prevents the
core/columnblock from being removed from the sidebar of thecore/columnsblock when one of thecore/columnblocks is locked(prevent removal).How?
Based on the behavior that when the number of columns is reduced from a sidebar, it is removed from the column block behind it, I have implemented the following:
minCount)Screenshots or screencast
64986419fd5fe58b5bc29d6e43a74970.mp4
E2E test
(Speed is reduced to 1/4)
92f210af0be2da1d76ee9130829dd825__online-video-cutter_com___1__AdobeExpress.mp4