-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try updated pattern category descriptions #45548
Conversation
|
array( | ||
'label' => _x( 'Featured', 'Block pattern category', 'gutenberg' ), | ||
'label' => _x( 'Call to Action', 'Block pattern category', 'gutenberg' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all commented out for now, but I would expect them to replace all the existing categories.
Can we split this in a different PR? I think we can go for now with the updated categories including a description.
In the other PR if we replace them we should have a |
Absolutely. I won't have time to pick up this PR again in the immediate future, but if you have bandwidth feel free to either push directly, or otherwise. |
I'll create a new PR for the descriptions, so we can keep this for a while that has the new categories info. Sounds good? |
Thank you! |
@ntsekouras can I close this one, since you've extracted pieces? |
Thank you! |
What?
Implements category descriptions suggested by @beafialho in #44501 (comment), as a starting point, and also includes some stubs for new proposed categories.
GIF showing the new category descriptions:
What's a good way to move forward with the future pattern categories? Do they need to be created in the pattern directory first? Do they require a core patch?
Perhaps more importantly, we probably want to remove the existing categories and replace them with the new categories, including the bundled patterns. What's the best way to do that?
Testing Instructions
Open the pattern inserter, then check each category for descriptions.