Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paste styles to the block settings #45477
Add paste styles to the block settings #45477
Changes from all commits
ca77cd7
c5e11e1
285089f
c2ef8a6
63783a0
dd1c5d2
2e8bcfc
a918587
991f685
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like there's one situation which is unhandled before this point is reached, and that's copy/pasting block content that has no style attributes. No error or warning is shown.
In that situation it might be good to show a message similar to the one above ("Unable to paste styles. Block styles couldn't be found within the copied content.")
It's very minor, so could be a small follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll override the style to the default values if there are any, so I wonder if that would be a common issue 🤔 . Agreed that it can be a follow-up. 👍