Update legacy-widget-block.md #44343
Conversation
`$control` is not the first argument passed to the event. Anyone who tries to use this code will encounter an error stating `$control.find is not a function`. This blog post will also need updating: https://make.wordpress.org/core/2021/06/29/block-based-widgets-editor-in-wordpress-5-8/
cameronjonesweb
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @cameronjonesweb! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
github-actions
bot
added
the
First-time Contributor
There was a problem hiding this comment.
Yes, it seems the event is the first parameter and the code needs an update. cc: @noisysocks to update post https://make.wordpress.org/core/2021/06/29/block-based-widgets-editor-in-wordpress-5-8/.
THank you for this fix 👍
skorasaurus
added
[Type] Developer Documentation
|
Done, thanks for the ping. |
|
@cameronjonesweb: Could you please rebase |
|
@noisysocks done |
$controlis not the first argument passed to the event. Anyone who tries to use this code as is will encounter an error stating$control.find is not a function.This blog post will also need updating: https://make.wordpress.org/core/2021/06/29/block-based-widgets-editor-in-wordpress-5-8/