Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump caniuse-lite version #41675

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Bump caniuse-lite version #41675

merged 2 commits into from
Jun 13, 2022

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jun 11, 2022

What?

Bump the version of caniuse-lite.

Why?

There's a new version of caniuse-lite and we need to bump to it to fix the following error while running tests:

Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db
  Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating

See #41674 for a related test failure.

How?

Simply running npx browserslist@latest --update-db which updated package-lock.json with the new version of caniuse-lite. We also update a few snapshot tests as needed.

Testing Instructions

Verify all tests pass and Gutenberg builds properly.

@tyxla tyxla added the npm Packages Related to npm packages label Jun 11, 2022
@tyxla tyxla requested a review from a team June 11, 2022 13:20
@tyxla tyxla self-assigned this Jun 11, 2022
@tyxla tyxla requested review from Mamaduka and luisherranz and removed request for a team June 11, 2022 13:20
@github-actions
Copy link

github-actions bot commented Jun 11, 2022

Size Change: -3.42 kB (0%)

Total Size: 1.24 MB

Filename Size Change
build/a11y/index.min.js 982 B -11 B (-1%)
build/annotations/index.min.js 2.73 kB -16 B (-1%)
build/api-fetch/index.min.js 2.26 kB -10 B (0%)
build/autop/index.min.js 2.14 kB -8 B (0%)
build/blob/index.min.js 475 B -12 B (-2%)
build/block-directory/index.min.js 6.49 kB -22 B (0%)
build/block-directory/style-rtl.css 990 B -22 B (-2%)
build/block-directory/style.css 991 B -21 B (-2%)
build/block-editor/index.min.js 151 kB -317 B (0%)
build/block-editor/style-rtl.css 14.5 kB -51 B (0%)
build/block-editor/style.css 14.5 kB -52 B (0%)
build/block-library/blocks/audio/theme-rtl.css 110 B -15 B (-12%) 👏
build/block-library/blocks/audio/theme.css 110 B -15 B (-12%) 👏
build/block-library/blocks/button/editor-rtl.css 441 B -4 B (-1%)
build/block-library/blocks/button/editor.css 441 B -4 B (-1%)
build/block-library/blocks/button/style-rtl.css 514 B -2 B (0%)
build/block-library/blocks/button/style.css 514 B -2 B (0%)
build/block-library/blocks/cover/style-rtl.css 1.55 kB -7 B (0%)
build/block-library/blocks/cover/style.css 1.55 kB -7 B (0%)
build/block-library/blocks/embed/theme-rtl.css 110 B -14 B (-11%) 👏
build/block-library/blocks/embed/theme.css 110 B -14 B (-11%) 👏
build/block-library/blocks/file/view.min.js 346 B -7 B (-2%)
build/block-library/blocks/freeform/editor-rtl.css 2.44 kB -2 B (0%)
build/block-library/blocks/gallery/editor-rtl.css 948 B -13 B (-1%)
build/block-library/blocks/gallery/editor.css 950 B -14 B (-1%)
build/block-library/blocks/gallery/style-rtl.css 1.5 kB -19 B (-1%)
build/block-library/blocks/gallery/style.css 1.49 kB -19 B (-1%)
build/block-library/blocks/gallery/theme-rtl.css 108 B -14 B (-11%) 👏
build/block-library/blocks/gallery/theme.css 108 B -14 B (-11%) 👏
build/block-library/blocks/html/editor-rtl.css 327 B -5 B (-2%)
build/block-library/blocks/html/editor.css 329 B -4 B (-1%)
build/block-library/blocks/image/theme-rtl.css 110 B -14 B (-11%) 👏
build/block-library/blocks/image/theme.css 110 B -14 B (-11%) 👏
build/block-library/blocks/navigation-link/editor-rtl.css 705 B -3 B (0%)
build/block-library/blocks/navigation-link/editor.css 703 B -3 B (0%)
build/block-library/blocks/navigation-submenu/editor-rtl.css 296 B -3 B (-1%)
build/block-library/blocks/navigation-submenu/editor.css 295 B -4 B (-1%)
build/block-library/blocks/navigation/editor-rtl.css 2.03 kB -1 B (0%)
build/block-library/blocks/navigation/editor.css 2.04 kB +1 B (0%)
build/block-library/blocks/navigation/style-rtl.css 1.94 kB -10 B (-1%)
build/block-library/blocks/navigation/style.css 1.93 kB -9 B (0%)
build/block-library/blocks/navigation/view-modal.min.js 2.78 kB -2 B (0%)
build/block-library/blocks/navigation/view.min.js 393 B -2 B (-1%)
build/block-library/blocks/post-featured-image/editor-rtl.css 605 B -14 B (-2%)
build/block-library/blocks/post-featured-image/editor.css 605 B -14 B (-2%)
build/block-library/blocks/shortcode/editor-rtl.css 464 B -10 B (-2%)
build/block-library/blocks/shortcode/editor.css 464 B -10 B (-2%)
build/block-library/blocks/site-logo/editor-rtl.css 708 B -13 B (-2%)
build/block-library/blocks/site-logo/editor.css 708 B -13 B (-2%)
build/block-library/blocks/spacer/editor-rtl.css 322 B -10 B (-3%)
build/block-library/blocks/spacer/editor.css 322 B -10 B (-3%)
build/block-library/blocks/table/editor-rtl.css 494 B -10 B (-2%)
build/block-library/blocks/table/editor.css 494 B -10 B (-2%)
build/block-library/blocks/table/style-rtl.css 621 B -4 B (-1%)
build/block-library/blocks/table/style.css 620 B -5 B (-1%)
build/block-library/blocks/table/theme-rtl.css 175 B -13 B (-7%)
build/block-library/blocks/table/theme.css 175 B -13 B (-7%)
build/block-library/blocks/video/style-rtl.css 169 B -4 B (-2%)
build/block-library/blocks/video/style.css 169 B -4 B (-2%)
build/block-library/blocks/video/theme-rtl.css 110 B -14 B (-11%) 👏
build/block-library/blocks/video/theme.css 110 B -14 B (-11%) 👏
build/block-library/common-rtl.css 987 B -6 B (-1%)
build/block-library/common.css 984 B -6 B (-1%)
build/block-library/editor-rtl.css 10.2 kB -40 B (0%)
build/block-library/editor.css 10.2 kB -42 B (0%)
build/block-library/index.min.js 181 kB -355 B (0%)
build/block-library/style-rtl.css 11.5 kB -30 B (0%)
build/block-library/style.css 11.5 kB -32 B (0%)
build/block-library/theme-rtl.css 677 B -12 B (-2%)
build/block-library/theme.css 682 B -12 B (-2%)
build/block-serialization-default-parser/index.min.js 1.11 kB -8 B (-1%)
build/block-serialization-spec-parser/index.min.js 2.83 kB -1 B (0%)
build/blocks/index.min.js 47 kB -95 B (0%)
build/components/index.min.js 227 kB -276 B (0%)
build/components/style-rtl.css 13.9 kB -48 B (0%)
build/components/style.css 13.9 kB -44 B (0%)
build/compose/index.min.js 11.7 kB -7 B (0%)
build/core-data/index.min.js 14.6 kB -66 B (0%)
build/customize-widgets/index.min.js 11.2 kB -23 B (0%)
build/data-controls/index.min.js 653 B -10 B (-2%)
build/data/index.min.js 7.95 kB -29 B (0%)
build/date/index.min.js 32 kB -5 B (0%)
build/deprecated/index.min.js 507 B -11 B (-2%)
build/dom-ready/index.min.js 324 B -12 B (-4%)
build/dom/index.min.js 4.65 kB -39 B (-1%)
build/edit-navigation/index.min.js 16 kB -32 B (0%)
build/edit-navigation/style-rtl.css 4.03 kB -15 B (0%)
build/edit-navigation/style.css 4.04 kB -16 B (0%)
build/edit-post/index.min.js 30.4 kB -108 B (0%)
build/edit-post/style-rtl.css 7.05 kB -30 B (0%)
build/edit-post/style.css 7.05 kB -30 B (0%)
build/edit-site/index.min.js 47.9 kB -62 B (0%)
build/edit-site/style-rtl.css 7.69 kB -35 B (0%)
build/edit-site/style.css 7.67 kB -35 B (0%)
build/edit-widgets/index.min.js 16.4 kB -48 B (0%)
build/edit-widgets/style-rtl.css 4.39 kB -18 B (0%)
build/edit-widgets/style.css 4.38 kB -18 B (0%)
build/editor/index.min.js 38.1 kB -262 B (-1%)
build/editor/style-rtl.css 3.63 kB -26 B (-1%)
build/editor/style.css 3.62 kB -24 B (-1%)
build/element/index.min.js 4.26 kB -48 B (-1%)
build/escape-html/index.min.js 537 B -11 B (-2%)
build/format-library/index.min.js 6.6 kB -20 B (0%)
build/hooks/index.min.js 1.64 kB -28 B (-2%)
build/html-entities/index.min.js 448 B -6 B (-1%)
build/i18n/index.min.js 3.77 kB -17 B (0%)
build/is-shallow-equal/index.min.js 527 B -8 B (-1%)
build/keyboard-shortcuts/index.min.js 1.79 kB -9 B (0%)
build/keycodes/index.min.js 1.38 kB -36 B (-3%)
build/list-reusable-blocks/index.min.js 1.74 kB -4 B (0%)
build/media-utils/index.min.js 2.89 kB -11 B (0%)
build/notices/index.min.js 945 B -12 B (-1%)
build/nux/index.min.js 2.05 kB -15 B (-1%)
build/nux/style-rtl.css 732 B -12 B (-2%)
build/nux/style.css 728 B -13 B (-2%)
build/plugins/index.min.js 1.97 kB -12 B (-1%)
build/preferences-persistence/index.min.js 2.22 kB -9 B (0%)
build/preferences/index.min.js 1.3 kB -15 B (-1%)
build/primitives/index.min.js 933 B -16 B (-2%)
build/priority-queue/index.min.js 612 B -16 B (-3%)
build/react-i18n/index.min.js 696 B -8 B (-1%)
build/react-refresh-entry/index.min.js 8.44 kB -5 B (0%)
build/react-refresh-runtime/index.min.js 7.31 kB +2 B (0%)
build/redux-routine/index.min.js 2.69 kB -1 B (0%)
build/reusable-blocks/index.min.js 2.23 kB -12 B (-1%)
build/rich-text/index.min.js 11.1 kB -35 B (0%)
build/server-side-render/index.min.js 1.61 kB -1 B (0%)
build/shortcode/index.min.js 1.51 kB -9 B (-1%)
build/token-list/index.min.js 662 B -6 B (-1%)
build/url/index.min.js 1.96 kB -30 B (-2%)
build/viewport/index.min.js 1.08 kB -8 B (-1%)
build/warning/index.min.js 268 B -12 B (-4%)
build/widgets/index.min.js 7.19 kB -13 B (0%)
build/widgets/style-rtl.css 1.16 kB -3 B (0%)
build/widgets/style.css 1.16 kB -3 B (0%)
build/wordcount/index.min.js 1.06 kB -5 B (0%)
ℹ️ View Unchanged
Filename Size
build/block-editor/default-editor-styles-rtl.css 378 B
build/block-editor/default-editor-styles.css 378 B
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 65 B
build/block-library/blocks/archives/style.css 65 B
build/block-library/blocks/audio/editor-rtl.css 150 B
build/block-library/blocks/audio/editor.css 150 B
build/block-library/blocks/audio/style-rtl.css 111 B
build/block-library/blocks/audio/style.css 111 B
build/block-library/blocks/avatar/editor-rtl.css 116 B
build/block-library/blocks/avatar/editor.css 116 B
build/block-library/blocks/avatar/style-rtl.css 59 B
build/block-library/blocks/avatar/style.css 59 B
build/block-library/blocks/block/editor-rtl.css 161 B
build/block-library/blocks/block/editor.css 161 B
build/block-library/blocks/buttons/editor-rtl.css 292 B
build/block-library/blocks/buttons/editor.css 292 B
build/block-library/blocks/buttons/style-rtl.css 275 B
build/block-library/blocks/buttons/style.css 275 B
build/block-library/blocks/calendar/style-rtl.css 207 B
build/block-library/blocks/calendar/style.css 207 B
build/block-library/blocks/categories/editor-rtl.css 84 B
build/block-library/blocks/categories/editor.css 83 B
build/block-library/blocks/categories/style-rtl.css 79 B
build/block-library/blocks/categories/style.css 79 B
build/block-library/blocks/code/style-rtl.css 103 B
build/block-library/blocks/code/style.css 103 B
build/block-library/blocks/code/theme-rtl.css 124 B
build/block-library/blocks/code/theme.css 124 B
build/block-library/blocks/columns/editor-rtl.css 108 B
build/block-library/blocks/columns/editor.css 108 B
build/block-library/blocks/columns/style-rtl.css 406 B
build/block-library/blocks/columns/style.css 406 B
build/block-library/blocks/comment-author-avatar/editor-rtl.css 125 B
build/block-library/blocks/comment-author-avatar/editor.css 125 B
build/block-library/blocks/comment-content/style-rtl.css 92 B
build/block-library/blocks/comment-content/style.css 92 B
build/block-library/blocks/comment-template/style-rtl.css 127 B
build/block-library/blocks/comment-template/style.css 127 B
build/block-library/blocks/comments-pagination-numbers/editor-rtl.css 123 B
build/block-library/blocks/comments-pagination-numbers/editor.css 121 B
build/block-library/blocks/comments-pagination/editor-rtl.css 222 B
build/block-library/blocks/comments-pagination/editor.css 209 B
build/block-library/blocks/comments-pagination/style-rtl.css 235 B
build/block-library/blocks/comments-pagination/style.css 231 B
build/block-library/blocks/comments-title/editor-rtl.css 75 B
build/block-library/blocks/comments-title/editor.css 75 B
build/block-library/blocks/comments/editor-rtl.css 95 B
build/block-library/blocks/comments/editor.css 95 B
build/block-library/blocks/cover/editor-rtl.css 615 B
build/block-library/blocks/cover/editor.css 616 B
build/block-library/blocks/embed/editor-rtl.css 293 B
build/block-library/blocks/embed/editor.css 293 B
build/block-library/blocks/embed/style-rtl.css 417 B
build/block-library/blocks/embed/style.css 417 B
build/block-library/blocks/file/editor-rtl.css 300 B
build/block-library/blocks/file/editor.css 300 B
build/block-library/blocks/file/style-rtl.css 252 B
build/block-library/blocks/file/style.css 253 B
build/block-library/blocks/freeform/editor.css 2.44 kB
build/block-library/blocks/group/editor-rtl.css 333 B
build/block-library/blocks/group/editor.css 333 B
build/block-library/blocks/group/style-rtl.css 57 B
build/block-library/blocks/group/style.css 57 B
build/block-library/blocks/group/theme-rtl.css 78 B
build/block-library/blocks/group/theme.css 78 B
build/block-library/blocks/heading/style-rtl.css 76 B
build/block-library/blocks/heading/style.css 76 B
build/block-library/blocks/image/editor-rtl.css 738 B
build/block-library/blocks/image/editor.css 737 B
build/block-library/blocks/image/style-rtl.css 529 B
build/block-library/blocks/image/style.css 535 B
build/block-library/blocks/latest-comments/style-rtl.css 284 B
build/block-library/blocks/latest-comments/style.css 284 B
build/block-library/blocks/latest-posts/editor-rtl.css 199 B
build/block-library/blocks/latest-posts/editor.css 198 B
build/block-library/blocks/latest-posts/style-rtl.css 463 B
build/block-library/blocks/latest-posts/style.css 462 B
build/block-library/blocks/list/style-rtl.css 88 B
build/block-library/blocks/list/style.css 88 B
build/block-library/blocks/media-text/editor-rtl.css 266 B
build/block-library/blocks/media-text/editor.css 263 B
build/block-library/blocks/media-text/style-rtl.css 493 B
build/block-library/blocks/media-text/style.css 490 B
build/block-library/blocks/more/editor-rtl.css 431 B
build/block-library/blocks/more/editor.css 431 B
build/block-library/blocks/navigation-link/style-rtl.css 115 B
build/block-library/blocks/navigation-link/style.css 115 B
build/block-library/blocks/navigation-submenu/view.min.js 375 B
build/block-library/blocks/nextpage/editor-rtl.css 395 B
build/block-library/blocks/nextpage/editor.css 395 B
build/block-library/blocks/page-list/editor-rtl.css 363 B
build/block-library/blocks/page-list/editor.css 363 B
build/block-library/blocks/page-list/style-rtl.css 175 B
build/block-library/blocks/page-list/style.css 175 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B
build/block-library/blocks/paragraph/editor.css 157 B
build/block-library/blocks/paragraph/style-rtl.css 260 B
build/block-library/blocks/paragraph/style.css 260 B
build/block-library/blocks/post-author/style-rtl.css 175 B
build/block-library/blocks/post-author/style.css 176 B
build/block-library/blocks/post-comments-form/editor-rtl.css 69 B
build/block-library/blocks/post-comments-form/editor.css 69 B
build/block-library/blocks/post-comments-form/style-rtl.css 495 B
build/block-library/blocks/post-comments-form/style.css 495 B
build/block-library/blocks/post-comments/editor-rtl.css 77 B
build/block-library/blocks/post-comments/editor.css 77 B
build/block-library/blocks/post-comments/style-rtl.css 628 B
build/block-library/blocks/post-comments/style.css 628 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B
build/block-library/blocks/post-excerpt/editor.css 73 B
build/block-library/blocks/post-excerpt/style-rtl.css 69 B
build/block-library/blocks/post-excerpt/style.css 69 B
build/block-library/blocks/post-featured-image/style-rtl.css 153 B
build/block-library/blocks/post-featured-image/style.css 153 B
build/block-library/blocks/post-template/editor-rtl.css 99 B
build/block-library/blocks/post-template/editor.css 98 B
build/block-library/blocks/post-template/style-rtl.css 323 B
build/block-library/blocks/post-template/style.css 323 B
build/block-library/blocks/post-terms/style-rtl.css 73 B
build/block-library/blocks/post-terms/style.css 73 B
build/block-library/blocks/post-title/style-rtl.css 80 B
build/block-library/blocks/post-title/style.css 80 B
build/block-library/blocks/preformatted/style-rtl.css 103 B
build/block-library/blocks/preformatted/style.css 103 B
build/block-library/blocks/pullquote/editor-rtl.css 198 B
build/block-library/blocks/pullquote/editor.css 198 B
build/block-library/blocks/pullquote/style-rtl.css 370 B
build/block-library/blocks/pullquote/style.css 370 B
build/block-library/blocks/pullquote/theme-rtl.css 167 B
build/block-library/blocks/pullquote/theme.css 167 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B
build/block-library/blocks/query-pagination/editor-rtl.css 221 B
build/block-library/blocks/query-pagination/editor.css 211 B
build/block-library/blocks/query-pagination/style-rtl.css 234 B
build/block-library/blocks/query-pagination/style.css 231 B
build/block-library/blocks/query/editor-rtl.css 369 B
build/block-library/blocks/query/editor.css 369 B
build/block-library/blocks/quote/style-rtl.css 213 B
build/block-library/blocks/quote/style.css 213 B
build/block-library/blocks/quote/theme-rtl.css 223 B
build/block-library/blocks/quote/theme.css 226 B
build/block-library/blocks/read-more/style-rtl.css 132 B
build/block-library/blocks/read-more/style.css 132 B
build/block-library/blocks/rss/editor-rtl.css 202 B
build/block-library/blocks/rss/editor.css 204 B
build/block-library/blocks/rss/style-rtl.css 289 B
build/block-library/blocks/rss/style.css 288 B
build/block-library/blocks/search/editor-rtl.css 165 B
build/block-library/blocks/search/editor.css 165 B
build/block-library/blocks/search/style-rtl.css 402 B
build/block-library/blocks/search/style.css 403 B
build/block-library/blocks/search/theme-rtl.css 64 B
build/block-library/blocks/search/theme.css 64 B
build/block-library/blocks/separator/editor-rtl.css 146 B
build/block-library/blocks/separator/editor.css 146 B
build/block-library/blocks/separator/style-rtl.css 233 B
build/block-library/blocks/separator/style.css 233 B
build/block-library/blocks/separator/theme-rtl.css 194 B
build/block-library/blocks/separator/theme.css 194 B
build/block-library/blocks/site-logo/style-rtl.css 192 B
build/block-library/blocks/site-logo/style.css 192 B
build/block-library/blocks/site-tagline/editor-rtl.css 86 B
build/block-library/blocks/site-tagline/editor.css 86 B
build/block-library/blocks/site-title/editor-rtl.css 84 B
build/block-library/blocks/site-title/editor.css 84 B
build/block-library/blocks/social-link/editor-rtl.css 177 B
build/block-library/blocks/social-link/editor.css 177 B
build/block-library/blocks/social-links/editor-rtl.css 674 B
build/block-library/blocks/social-links/editor.css 673 B
build/block-library/blocks/social-links/style-rtl.css 1.37 kB
build/block-library/blocks/social-links/style.css 1.36 kB
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/tag-cloud/style-rtl.css 226 B
build/block-library/blocks/tag-cloud/style.css 227 B
build/block-library/blocks/template-part/editor-rtl.css 149 B
build/block-library/blocks/template-part/editor.css 149 B
build/block-library/blocks/template-part/theme-rtl.css 101 B
build/block-library/blocks/template-part/theme.css 101 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 166 B
build/block-library/blocks/text-columns/style.css 166 B
build/block-library/blocks/verse/style-rtl.css 87 B
build/block-library/blocks/verse/style.css 87 B
build/block-library/blocks/video/editor-rtl.css 561 B
build/block-library/blocks/video/editor.css 563 B
build/block-library/reset-rtl.css 478 B
build/block-library/reset.css 478 B
build/customize-widgets/style-rtl.css 1.4 kB
build/customize-widgets/style.css 1.4 kB
build/edit-post/classic-rtl.css 546 B
build/edit-post/classic.css 547 B
build/format-library/style-rtl.css 571 B
build/format-library/style.css 571 B
build/list-reusable-blocks/style-rtl.css 835 B
build/list-reusable-blocks/style.css 835 B
build/reusable-blocks/style-rtl.css 256 B
build/reusable-blocks/style.css 256 B
build/vendors/react-dom.min.js 38.5 kB
build/vendors/react.min.js 4.34 kB

compressed-size-action

@tyxla tyxla added [Type] Build Tooling Issues or PRs related to build tooling and removed npm Packages Related to npm packages labels Jun 11, 2022
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been hit by this outdated complaint so I'll approve this. What's with the

editor/blocks/image.spec.js:34:2 › Image › can be inserted =======================
    {
      code: 'internal_server_error',
      message: '<p>There has been a critical error on this website.</p><p><a href="https://wordpress.org/support/article/faq-troubleshooting/">Learn more about troubleshooting WordPress.</a></p>',
      data: { status: 500 },
      additional_errors: []
    }

Hopefully unrelated and will pass on a restart.

@tyxla
Copy link
Member Author

tyxla commented Jun 13, 2022

Thanks @draganescu, it's all green, so I'll merge ✅

@tyxla tyxla merged commit e83c108 into trunk Jun 13, 2022
@tyxla tyxla deleted the upgrade/caniuse-lite branch June 13, 2022 06:18
@github-actions github-actions bot added this to the Gutenberg 13.5 milestone Jun 13, 2022
@swissspidy
Copy link
Member

Has it been considered to do this update regularly using a GitHub action?

Here's what I use for that:

https://github.com/GoogleForCreators/web-stories-wp/blob/9fd878fd739831cfd941e5384fb1cf3f190c2d1d/.github/workflows/update-browserslist.yml#L20-L43

@tyxla
Copy link
Member Author

tyxla commented Jun 13, 2022

My personal opinion is that it still would require a human touch since it touches package-lock.json and there can be unexpected results because of this. For example, one thing I've noticed is that it changes tabs to spaces - easily reversible of course. Another is that when run on a different (supported) node version, it can produce much more updates on package-lock.json than expected - this occurred to me locally, because I was running a different node version. Maybe that would never occur if we pin it to a specific node version.

However, judging by how often it occurs it's likely a good idea to automate it 👍

@annezazu annezazu added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants