-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packages: Add command to publish to npm targeting WP major release #40927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b82e077
to
e9252a3
Compare
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
adamziel
reviewed
May 9, 2022
|
||
if ( releaseType === 'wp' ) { | ||
log( | ||
'>> Skipping CHANGELOG files processing when targeting WordPress core.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
adamziel
approved these changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is great! I like seeing all the progress towards automating the release, good job 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of the efforts to automate npm publishing as discussed in #37820.
Adds a new command that automates the process of publishing npm packages targeting the given major WordPress release.
Why?
At the moment the process of publishing to npm changes targeting the current major WordPress release is very manual and repeats every week. We want to automate it with GitHub action that runs behind the scenes the following:
How?
Introduce a new command
npm-wp
for the./bin/plugin/cli.js
tool that we have been using for npm publishing for quite some time.Testing Instructions
Ensure that the
--wp-version
option is mandatory:Ensure that the command runs correctly when the WP version is provided:
Screenshots or screencast
Test run:
I managed to publish npm packages with this action:
I verified that the
@wordpress/[email protected]
has the correctdist-tag
applied:wp-6.0
.