Pullquote block: Fix citation markup in Editor #39414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndiego
added
[Type] Bug
|
Size Change: +4.77 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
|
Works well in the editors, thank you. The failing tests seems unrelated. |
|
Thanks for reviewing @carolinan, I'll give it a day or so and rebase to try and clear the failing tests. They do appear unrelated. |
|
Thanks @ndiego related issue: #19847 There is another PR for this already at #38610 ; I didn't check whether the two approaches are the same. For what it's worth: This arose when I was investigating my own organization's internal use of the pullquote block a few months ago: The cite element may not be the most appropriate HTML element to be used because it is to only be used to refer to a published work and not to be used to refer to a person (which my org have been using it as such for some time) which states that "person's name is not the title of a work — even if people call that person a piece of work" there is an issue discussing the appropriate HTML element #20606 I understand that the ship (of using the cite element) has already sort of sailed so but thought you and any other reviews should know. |
|
Thanks for calling this out @skorasaurus, I missed that other PR! This PR matches the current quote block implementation exactly. Understanding the potential concerns around the use of |
|
All tests have passed, just waiting on approval |
aristath
reviewed
Mar 18, 2022
aristath
approved these changes
Mar 18, 2022
This was referenced Mar 20, 2022
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
* Pullquote: Fix citation markup in Editor * Fix linting error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR changes the pullquote citation markup in the Editor from
<div>to<cite>to improve consistency between the Editor and Frontend. The Frontend already uses<cite>.Why?
This bug appears to have been an oversight, the quote block already has this fix. This PR copies the quote block implementation exactly.
Testing Instructions
<cite>, and so is the Frontend.Props to @mrleemon for the original PR: #38610