Add: End to end tests for style variations. #38485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Automated Testing
jorgefilipecosta
requested review from
ajitbohra,
nerrad and
ntwb
as code owners
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
add/end-to-end-test-for-style-variations
branch
2 times, most recently
from
ba2796b to
e8edad0
Compare
jorgefilipecosta
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
jorgefilipecosta
force-pushed
the
add/end-to-end-test-for-style-variations
branch
from
e8edad0 to
cd4f336
Compare
youknowriad
reviewed
Feb 4, 2022
lib/compat/wordpress-6.0/class-gutenberg-rest-global-styles-controller.php
Show resolved
Hide resolved
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import { siteEditor } from './utils'; |
There was a problem hiding this comment.
In a recent PR, these utils has been moved to e2e-test-utils, so a rebase might break things here.
| await applyVariation( 2 ); | ||
| } | ||
|
|
||
| async function openGlobalStylesPanel( panelName ) { |
There was a problem hiding this comment.
This one could potentially be an e2e test util.
jorgefilipecosta
force-pushed
the
add/end-to-end-test-for-style-variations
branch
from
cd4f336 to
adada92
Compare
jorgefilipecosta
force-pushed
the
add/end-to-end-test-for-style-variations
branch
from
adada92 to
923c84e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #35619.
Adds end-to-end tests for the style variations.
Adds a test theme with some style variations so end to end tests can use it.