Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Minor retouches to test-create-block script #38482

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Testing: Minor retouches to test-create-block script #38482

merged 1 commit into from
Feb 3, 2022

Conversation

mcsf
Copy link
Contributor

@mcsf mcsf commented Feb 3, 2022

Follows up on #38368

Types of changes

Code quality

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@mcsf mcsf added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality [Tool] WP Scripts /packages/scripts [Tool] Create Block /packages/create-block labels Feb 3, 2022
@mcsf mcsf requested review from ockham and gziolo February 3, 2022 11:44
@mcsf mcsf mentioned this pull request Feb 3, 2022
Merged
gziolo
gziolo approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for improving this GitHub workflow 💯

@mcsf
Copy link
Contributor Author

mcsf commented Feb 3, 2022

Awesome, thank you for improving this GitHub workflow 💯

Just to be safe: does it test well too?

@gziolo
Copy link
Member

gziolo commented Feb 3, 2022

Yes, create block passes all the checks on Windows in https://github.com/WordPress/gutenberg/runs/5051005806?check_suite_focus=true.

@gziolo gziolo merged commit 09e4930 into trunk Feb 3, 2022
@gziolo gziolo deleted the update/ci-create-block-script-polish branch February 3, 2022 13:11
@github-actions github-actions bot added this to the Gutenberg 12.6 milestone Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@ockham ockham Awaiting requested review from ockham

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

Assignees
No one assigned
Labels
[Tool] Create Block /packages/create-block [Tool] WP Scripts /packages/scripts [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 12.6
Development

Successfully merging this pull request may close these issues.
2 participants
@mcsf @gziolo