Storybook: Update to the version 6.4 #37367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
mirka
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
No regressions noticeable for me either 👍
Probably doesn't solve the npm 8 problem you're describing, but it does seem like they have a cleaner workaround for the alias hack now:
- managerWebpack: updateEmotionAliases,
+ features: { emotionAlias: false },Line 50 in 1786db8
|
@mirka, would you mind opening a follow-up PR with the fix you mentioned? It looks like they want to include Emotion 11 support in Storybook 7. |
7 tasks
|
Followed up with some config migration in #37544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Storybook 6.4 is out: https://storybook.js.org/blog/storybook-6-4/.
I hoped that they added support for Emotion v11, but it's still not resolved storybookjs/storybook#13300. I'm trying to make Gutenberg work with npm 8 and seems to have issues with 2 different versions of Emotion used in the lock file.
How has this been tested?
I executed:
npm run storybook:buildEverything looked like before but I didn't do very in-depth testing.
Types of changes
New feature (non-breaking change which adds functionality).
Checklist:
*.native.jsfiles for terms that need renaming or removal).