Site editor: remove extra border radius. #37022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: -23 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
Thanks for testing! You may be more familiar with the cases where the iframe doesn't go edge to edge, the cases where you should see the dark gray frame. Did you test those to see if they all have the right radius when they need to. |
|
Yup, the radii are applied correctly in the post editor's template editing interface, and template part focus mode. Those are the only instances in which the dark frame appears for now. |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you look closely at the top left and right corners of the site editor, you can spot a dark gray background peeking through a tiny 2px border radius:
As best I can tell, the rule was introduced in #34732 to apply the correct 2px border radius for when the editing canvas is scaled down, surrounded by the dark frame. However it doesn't seem like this particular rule is needed anymore, as a separate 2px border radius is already applied conditionaly when the frame is applied.
So this PR removes it:
Am I missing a use case where the border needs to be applied?
Checklist:
*.native.jsfiles for terms that need renaming or removal).