Fix initial theme content not showing for navigation block within navigation area #36503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: +20 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
talldan
added
the
Backport to WP 6.7 Beta/RC
|
Sounds like the Navigation Area block might be reverted (#36524), so we can hold off on this for now. |
talldan
added
the
[Status] Blocked
talldan
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #36306
As described in that issue, themes should be able to implement a navigation area containing a navigation block with some initial starter content using something like the following markup:
This was working on the frontend (the page list would be rendered), but the editor was still showing the block placeholder for this HTML. It should instead show the Page List block and allow the user to edit and save this initial content.
The fix is a matter of adjusting some (slightly complicated) boolean logic in the navigation block for when the 'UnsavedInnerBlocks' should be shown.
How has this been tested?
This should be an easier way to validate the fix without needing to edit site templates, but some fuller testing on Twenty Twenty would be welcome too:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).