Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert/empty placeholder #3650

Merged
merged 2 commits into from
Nov 27, 2017
Merged

Revert/empty placeholder #3650

merged 2 commits into from
Nov 27, 2017

Conversation

youknowriad
Copy link
Contributor

revert #3623

This will give us more time to work on the "Empty Placeholder"

@youknowriad youknowriad force-pushed the revert/empty-placeholder branch from 4709980 to 97e439f Compare November 24, 2017 15:39
@jasmussen
Copy link
Contributor

😭

I'm going to miss this. Honestly, the "below the block list" chrome feels a bit heavy in comparison. I look forward to if/when we can revisit this.

For now this works well for me, thank you as usual Riad, 👍 👍

@youknowriad youknowriad force-pushed the revert/empty-placeholder branch from 97e439f to 8ef1f3d Compare November 27, 2017 07:26
@codecov
Copy link

codecov bot commented Nov 27, 2017

Codecov Report

Merging #3650 into master will decrease coverage by 0.03%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3650      +/-   ##
==========================================
- Coverage   37.07%   37.03%   -0.04%     
==========================================
  Files         276      277       +1     
  Lines        6656     6763     +107     
  Branches     1211     1230      +19     
==========================================
+ Hits         2468     2505      +37     
- Misses       3530     3585      +55     
- Partials      658      673      +15
Impacted Files Coverage Δ
editor/store-defaults.js 100% <ø> (ø) ⬆️
editor/edit-post/modes/visual-editor/index.js 0% <0%> (ø) ⬆️
editor/reducer.js 90.27% <100%> (+0.27%) ⬆️
editor/selectors.js 93.12% <100%> (+0.26%) ⬆️
editor/components/default-block-appender/index.js 88.88% <100%> (+1.38%) ⬆️
editor/edit-post/modes/visual-editor/inserter.js 93.33% <93.33%> (ø)
blocks/library/button/index.js 11.59% <0%> (-3.12%) ⬇️
blocks/library/image/block.js 1.28% <0%> (-0.45%) ⬇️
blocks/library/paragraph/index.js 25.8% <0%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f51ec08...8ef1f3d. Read the comment docs.

@youknowriad
Copy link
Contributor Author

Don't worry @jasmussen I'll bring it back when I have some time

@youknowriad youknowriad merged commit 8db5772 into master Nov 27, 2017
@youknowriad youknowriad deleted the revert/empty-placeholder branch November 27, 2017 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants