Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Remove inject polyfill by default #35436

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Scripts: Remove inject polyfill by default #35436

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33386a6
Remove inject polyfill default
mkaz Oct 7, 2021
f6b2bfc
Update CHANGELOG for breaking change
mkaz Oct 7, 2021
734ee04
Update packages/scripts/CHANGELOG.md
mkaz Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/scripts/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Breaking Changes

- The webpack config was update to no longer include the polyfill by default when creating the assets.php file. If your usage requires the wp-polyfill, you must explictly set it as a dependency. ([#34536](https://github.com/WordPress/gutenberg/pull/35436)]
mkaz marked this conversation as resolved.
Show resolved Hide resolved

### Enhancements

- The bundled `jest-dev-server` dependency has been updated to the next major version `^5.0.3` ([#34560](https://github.com/WordPress/gutenberg/pull/34560)).
Expand Down
2 changes: 1 addition & 1 deletion packages/scripts/config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ const config = {
// WP_NO_EXTERNALS global variable controls whether scripts' assets get
// generated, and the default externals set.
! process.env.WP_NO_EXTERNALS &&
new DependencyExtractionWebpackPlugin( { injectPolyfill: true } ),
new DependencyExtractionWebpackPlugin(),
].filter( Boolean ),
stats: {
children: false,
Expand Down