Navigation Screen: Use response messages returned from API for notices #34903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
adamziel,
draganescu,
getdave,
kevin940726,
talldan and
tellthemachines
as code owners
Mamaduka
added
[Feature] Navigation Screen
[Type] Enhancement
Mamaduka
changed the title
Closed
|
Ugh, I forgot that updating |
Mamaduka
force-pushed
the
try/nav-screen-response-message-notices
branch
from
c5fc62c to
3169ecc
Compare
|
Size Change: -38 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
try/nav-screen-response-message-notices
branch
from
3169ecc to
af63be0
Compare
Mamaduka
force-pushed
the
try/nav-screen-response-message-notices
branch
from
af63be0 to
ff22928
Compare
|
Re-ran the tests, but no luck so-far. Trying again now 🤞 |
|
Thanks, Daniel. I'm also a little worried that merging this will cause checks to fail on the trunk. |
|
Me too, from what I understand the test has to pass the currently failing step to store the npm cache. Without that they'll likely fail in |
|
Although I recall I had a PR with a package update, and despite passing tests in the PR merging still caused failing tests in |
|
I can duplicate |
|
I decided to copy |
|
Sounds good, thanks for sorting it. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #34884.
Updates the
AddMenucomponent to use error messages returned by API response and display them as notices.PR adds
@wordpress/domas a dependency to usestripHTMLmethod.How has this been tested?
Screenshots
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).