Prevent useConstrainedTabbing from stealing focus from elements with tabindex="-1" #34684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
[Focus] Accessibility (a11y)
|
Size Change: +1.66 kB (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
… after the last one
2 tasks
|
I'm wondering: could we use |
|
Here's a little experiment: #34836. |
7 tasks
johnbillion
deleted the
fix/34681-useConstrainedTabbing-tabindex-1-focus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34681.
Description
If an element with
tabindex="-1"is focused and is rendered inside a component usinguseConstrainedTabbing(), pressing Tab will not focus the next focusable element, but instead it will go back to the first focusable item. This PR fixes that modifying the check so it no longer relies on the list of tabbable elements (which doesn't include elements withtabindex="-1".Notice that the solution implemented in commit c0dd4ee was already proposed some time ago, but it wasn't applied because it didn't work well with IE11. However, now that IE11 is no longer supported, it should be good to go.
e1be9f2 fixes the case when the element with
tabindex="-1"is before or after all tabbable items.How has this been tested?
See Testing instructions below. In addition, I tested several components that use
Modalto verify there are no regressions.Testing instructions
One way to verify #34681 is fixed is to modify the
<Modal>story:gutenberg/packages/components/src/modal/stories/index.js
Lines 31 to 35 in 9df736c
Like this:
<Modal { ...props } onRequestClose={ closeModal }> + <Button>Button 1</Button> + <div className="placeholder-div" tabIndex={ -1 } /> + <Button>Button 2</Button> + <Button + onClick={ () => { + const placeholder = document.querySelector( + '.placeholder-div' + ); + placeholder.focus(); + } } + > + Button 3 + </Button> <Button variant="secondary" onClick={ closeModal }> Close Modal </Button> </Modal>npm run storybook.Button 3..placeholder-div.Button 2instead of the close button.<div className="placeholder-div" tabIndex={ -1 } />before or after all buttons and verify focus never escapes the modal. (That's what's fixed in e1be9f2).Screenshots
Before:
actual.mp4
After:
expected.mp4
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).