Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing field _invalid in menu item REST API #34670

Merged
merged 7 commits into from
Sep 14, 2021
Merged

Add missing field _invalid in menu item REST API #34670

merged 7 commits into from
Sep 14, 2021

Conversation

spacedmonkey
Copy link
Member

@spacedmonkey spacedmonkey commented Sep 8, 2021 •
edited
Loading

Description

Add missing field _invalid in menu item REST API. Originally flagged in #34628

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

Fixes #34628

@spacedmonkey spacedmonkey self-assigned this Sep 8, 2021
@spacedmonkey spacedmonkey requested a review from talldan September 8, 2021 21:59
noisysocks
noisysocks reviewed Sep 13, 2021
View reviewed changes
Copy link
Member

@noisysocks noisysocks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the extra attribute to get_item_schema and modify any unit tests that test get_item. Also, does it need to be prefixed with _? I didn't think that was a convention that the REST API ever used.

@TimothyBJacobs
Copy link
Member

I agree with @noisysocks.

@spacedmonkey
Copy link
Member Author

We should add the extra attribute to get_item_schema

To be clear, it was already there, we just didn't return it.

modify any unit tests that test get_item

Added to tests.

Also, does it need to be prefixed with _?

Removed

noisysocks
noisysocks approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

@spacedmonkey spacedmonkey mentioned this pull request Sep 14, 2021
Closed
@spacedmonkey spacedmonkey merged commit 4aaf626 into trunk Sep 14, 2021
@spacedmonkey spacedmonkey deleted the fix/_invalid branch September 14, 2021 20:30
@github-actions github-actions bot added this to the Gutenberg 11.6 milestone Sep 14, 2021
fullofcaffeine added a commit that referenced this pull request Sep 16, 2021
@fullofcaffeine
Merge branch 'trunk' into replace/confirm-et-al
33e97e1 
* trunk: (74 commits)
  Update docs for ClipboardButton component (#34711)
  Post Title Block: add typography formatting options (#31623)
  Bump plugin version to 11.5.0
  Navigation Screen: Adjust header toolbar icon styles (#34833)
  Fix the parent menu item field in REST API responses (#34835)
  Rewrite FocusableIframe as hook API (#26753)
  Create Block: Remove wp-cli callout since not recommended and outdated (#34821)
  Global Styles: Fix dimensions panel default controls display (#34828)
  [RNMobile][Embed block] Enable embed preview for Instagram and Vimeo providers (#34563)
  Increase Link UI search results to 10 on Nav Editor screen (#34808)
  Prevent welcome guide overflow x scroll (#34713)
  Enable open on click for Page List inside Navigation. (#34675)
  [RNMobile] [Embed block] -  Unavailable preview fallback bottom sheet title update  (#34674)
  Add missing field _invalid in menu item REST API (#34670)
  Fix Dropdown/DropdownMenu toggle closing in all UAs (#31170)
  Navigation submenu block: replace global shortcut event handlers with local ones (#34812)
  Navigation Screen: Consolidate menu name and switcher (#34786)
  Remove parent and position validation from menu item REST API endpoint (#34672)
  Clean theme data when switching themes in the customizer (#34540)
  Components: add reset timeout to ColorPicker's copy functionality. (#34601)
  ...
@talldan talldan mentioned this pull request Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisysocks noisysocks noisysocks approved these changes

@TimothyBJacobs TimothyBJacobs TimothyBJacobs approved these changes

@talldan talldan Awaiting requested review from talldan

@adamziel adamziel Awaiting requested review from adamziel

Assignees

@spacedmonkey spacedmonkey

Labels
REST API Interaction Related to REST API
Projects
None yet
Milestone
Gutenberg 11.6
Development

Successfully merging this pull request may close these issues.

schema for "/__experimental/menu-items" errors
4 participants
@spacedmonkey @TimothyBJacobs @noisysocks @talldan