Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Update block variations documentation about block scope #34455

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

ntsekouras
Copy link
Contributor

Description

Based on this comment:

Sorry to add this to a closed issue. But I found it is very elusive in the documentation how to use the variations picker if block scope is chosen. I had to find it digging into the core src, comparing groups & columns.

For example, when creating variations on the core group block, the variations picker is not found. Yet, it allows me to choose block scope, while this doesnt do anything (because there is no <__experimentalBlockVariationPicker /> in core/group).

Would it be helpful if this is mentioned somewhere in the docs? (if you choose block scope, make sure there is a variation picker)

This PR tries to better clarify the usage of block scope in block variations. It also updates the BlockVariationPicker README file as is now linked from block variations docs page.

@ntsekouras ntsekouras added [Type] Developer Documentation Documentation for developers [Feature] Block Variations Block variations, including introducing new variations and variations as a feature labels Sep 1, 2021
@ntsekouras ntsekouras self-assigned this Sep 1, 2021
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great enhancement to the documentation related to block variations. Thank you for bringing more clarity ❤️

@ntsekouras ntsekouras merged commit 93ab227 into trunk Sep 1, 2021
@ntsekouras ntsekouras deleted the docs/update-block-variations-scope-info branch September 1, 2021 15:23
@github-actions github-actions bot added this to the Gutenberg 11.5 milestone Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants