Consolidate the PATHS_WITH_MERGE constant to one instance #34407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
commented
Aug 31, 2021
packages/blocks/README.md
Outdated
| @@ -665,6 +665,10 @@ _Returns_ | |||
|
|
|||
| - `Array|string`: A list of blocks or a string, depending on `handlerMode`. | |||
|
|
|||
| ### PATHS_WITH_MERGE | |||
|
|
|||
| Undocumented declaration. | |||
There was a problem hiding this comment.
I'm not 100% sure what this is used for!
There was a problem hiding this comment.
If the variable name is __EXPERIMENTAL_PATHS_TO_MERGE the doc generator will skip it. It's best if it's experimental at the moment. We may be able to do this differently later.
annezazu
added
[Type] Code Quality
|
Size Change: +7 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
oandregal
reviewed
Sep 2, 2021
oandregal
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As suggested in #34073 (comment), this consolidates the two instances of PATHS_WITH_MERGE to one definition and moves it to the constants file.
How has this been tested?
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).