Navigation Screen: Decode entities in the menu names #34263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
adamziel,
draganescu,
getdave,
kevin940726,
talldan and
tellthemachines
as code owners
|
Sidenote: We might want to decode menu name entities in the |
Mamaduka
added
[Feature] Navigation Screen
[Type] Bug
|
Size Change: -493 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
Looks good, I spotted this location as well when testing: |
|
Thanks for catching this, @talldan. It should be fixed now. |
adamziel
approved these changes
Aug 27, 2021
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes the issue when menu names with special characters are displayed incorrectly.
Fixes #34223.
How has this been tested?
Names & Entitiesor any special entities.Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).