RNmobile: Fix the cancel button on Block Variation Picker / Columns Block #34249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enejb
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
enejb
changed the title
dcalhoun
approved these changes
Aug 24, 2021
geriux
pushed a commit
that referenced
this pull request
Aug 25, 2021
5 tasks
7 tasks
geriux
pushed a commit
that referenced
this pull request
Aug 26, 2021
* Release script: Update react-native-editor version to 1.60.0 * Release script: Update with changes from 'npm run core preios' * Update changelog * Release script: Update react-native-editor version to 1.60.1 * Release script: Update with changes from 'npm run core preios' * RNmobile: Fix the cancel button on Columns Block (#34249) * Mobile - Update changelog * Fix Column bottom sheet Android close button (#34332) * Fix Column bottom sheet Android close button Apply required margin and padding to properly align Android close button in the Column block bottom sheet. * Update changelog * Mobile - Update changelog Co-authored-by: Enej Bajgoric <[email protected]> Co-authored-by: David Calhoun <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #34018 we refactored how we apply the padding the buttons in the navigation header. This Pr add the padding that we missed to add to the columns grid block.
Description
Add padding to button to fix spacing.
How has this been tested?
iOS Simulator add the layout grid block notice that the cancel button has the correct padding applied.
Screenshots
Before:
After:
Related
Automattic/block-experiments#238
Types of changes
Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).