Remove the __unstableLocation attribute prior to rendering #33175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the __unstableLocation attribute before passing the attributes to the menu renderer to avoid an infinate loop if no menu is assigned to the location.
MaggieCabrera
added
[Block] Navigation
scruffian
reviewed
Jul 6, 2021
| $location = $attributes['__unstableLocation']; | ||
| $maybe_classic_navigation = gutenberg_render_menu_from_location( $location, $attributes ); | ||
| $location = $attributes['__unstableLocation']; | ||
| $attributes['__unstableLocation'] = null; |
There was a problem hiding this comment.
could this be unset( $attributes['__unstableLocation'] )?
There was a problem hiding this comment.
Yea, that works better, thank you.
I am including that change in this PR.
|
This fix is included in this PR which is moving this effected logic to another location. If that PR gains traction this one should be closed. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the __unstableLocation attribute before passing the attributes to
the menu renderer to avoid an infinate loop if no menu is assigned to
the location.
How has this been tested?
Activate a theme that uses the Navigation block and an __unstableLocation attribute. Don't assign a menu to that location and attempt to render the site (any page that renders the menu block).
Note that before the fix WordPress runs out of memory (assuming due to an infinite loop).
With the fix the page renders as expected.
Types of changes
A simple bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).