Improve high contrast mode rendering of icon buttons. #33062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Focus] Accessibility (a11y)
jasmussen
requested review from
ajitbohra,
chrisvanpatten and
ellatrix
as code owners
|
Size Change: +167 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
|
High contrast mode before PR
High contrast mode after PR
Windows 10 Edge v91.0 I end up seeing white text and not yellow like you show, my high contrast settings look like this:
|
|
Awesome, thanks for testing. I think the color defaults may have changed as well in newer versions. |
|
✅ ? |
jasmussen
force-pushed
the
try/high-contrast-mode-improvements
branch
from
a06f147 to
30c711b
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #33022. Windows has, for a while, had a "high contrast mode", which drastically increases contrast of the operating system and webpages. This has included replacing background images and colors with a canvas color, replacing any and all text colors with a yellow text color, links with white, doing the same for borders and outlines. Notably, box-shadows are removed entirely, whereas even transparent outlines are made opaque, which we have leveraged across focus styles to ensure highly legible focus styles for high contrast modes.
It appears that as Microsoft has moved from Trident-based Edge to Chromium-based Edge, the particular rendering heuristic has also changed how it renders SVGs, essentially classifying them as decorative and therefore not changing the colors:
The good news is, there are new tools and HTML standardized mechanisms for handling high contrast mode(s), which makes it easy to address:
In the case of this PR, I've simply applied
CanvasTextcolor to any SVG we use for icon buttons.How has this been tested?
If you're a Windows user:
If you're not a Windows user, this one is a bit trickier. One way to do it is this:
Passw0rd!, because of course it is.Checklist:
*.native.jsfiles for terms that need renaming or removal).