-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct wrong setState call #32808
Correct wrong setState call #32808
Conversation
setState was called with only the value, not the key/value pair as an object
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Luke1982! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Hi there! thanks for the PR. I think right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve and merge changes since there has been no activity for some time, and the changes are correct.
I started working on replacing withState
with the useState
hook. The first part can be found here #33173. I will handle additional changes requested in the upcoming PR.
Congratulations on your first merged pull request, @Luke1982! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
The `setState` was called with only the value, not the key/value pair as an object.
@Luke1982 pinging you again to see if you can help confirm your WordPress.org username so you can be properly credited in the WordPress 5.9 release? Thanks! |
setState was called with only the value, not the key/value pair as an object
Description
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).