[RNMobile] iOS: Fixes frozen editor scrolling in landscape on iPhone #31795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +9 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
antonis
added
[Status] In Progress
|
Note that an alternative native iOS approach to this is also investigated. |
antonis
force-pushed
the
fix/16476-iosLandscapeScrolling
branch
from
c9b2088 to
1101bc7
Compare
Merged
2 tasks
Closed
4 tasks
geriux
reviewed
May 14, 2021
packages/components/src/mobile/keyboard-avoiding-view/index.ios.js
Outdated
Show resolved
Hide resolved
added 2 commits
May 14, 2021 14:46
geriux
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/WordPress-iOS#16476
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3504WordPress-iOSPR: wordpress-mobile/WordPress-iOS#16497Description
Sets keyboard vertical offset to zero in landscape mode to avoid frozen editor scrolling editor in landscape mode
How has this been tested?
You can get a build from the iOS PR
Note: There is known scrolling issue at a middle spot of the screen
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).