Add e2e tests for Widgets Customizer #31185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
kevin940726
force-pushed
the
add/widgets-customizer-e2e
branch
2 times, most recently
from
0ec661a to
90c9f36
Compare
kevin940726
requested review from
tellthemachines,
talldan,
noisysocks and
draganescu
noisysocks
approved these changes
Apr 28, 2021
| beforeAll( async () => { | ||
| // TODO: Ideally we can bundle our test theme directly in the repo. | ||
| await activateTheme( 'twentytwenty' ); | ||
| await deactivatePlugin( |
There was a problem hiding this comment.
Why disable this? It helps speed up tests.
There was a problem hiding this comment.
The editor doesn't load if we have this plugin enabled. It's probably a bug though.
There was a problem hiding this comment.
Ooohhh that's weird, I can repro the issue by adding * { animation-duration: 0ms !important; animation-delay: 0s !important; transition-duration: 0s !important; transition-delay: 0s !important; } to one of the customize widgets stylesheets.
There was a problem hiding this comment.
Maybe we are relying on transitionend to initialise things.
There was a problem hiding this comment.
I think we are! Hmm, we should fix this as anyone using a browser extension to disable animations, or a custom stylesheet hack, won't be able to access the screen.
There was a problem hiding this comment.
Actually I think this is also a bug from core 😅. The completeCallback is registered within the _animateChangeExpanded callback, which never gets fired since it's listening the transitionend event.
7 tasks
tellthemachines
approved these changes
Apr 28, 2021
| beforeAll( async () => { | ||
| // TODO: Ideally we can bundle our test theme directly in the repo. | ||
| await activateTheme( 'twentytwenty' ); | ||
| await deactivatePlugin( |
There was a problem hiding this comment.
Ooohhh that's weird, I can repro the issue by adding * { animation-duration: 0ms !important; animation-delay: 0s !important; transition-duration: 0s !important; transition-delay: 0s !important; } to one of the customize widgets stylesheets.
| } ).toBeFound( findOptions ); | ||
|
|
||
| expect( console ).toHaveWarned( | ||
| "The page delivered both an 'X-Frame-Options' header and a 'Content-Security-Policy' header with a 'frame-ancestors' directive. Although the 'X-Frame-Options' header alone would have blocked embedding, it has been ignored." |
There was a problem hiding this comment.
When does this warning happen? I don't see it in the browser console when adding blocks manually.
There was a problem hiding this comment.
I think it's a puppeteer thing, we might have to enable some flag to disable the warning. Not sure if it's safe to do so though.
kevin940726
force-pushed
the
add/widgets-customizer-e2e
branch
from
bd31797 to
219d9a5
Compare
|
I'm getting some intermittent failures now and then: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #30269. Add some basic e2e tests for Widgets Customizer.
This PR also updates
puppeteer-testing-libraryto v0.4.0. The full changelog can be seen here.How has this been tested?
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).