Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserter: Fix misaligned tooltip for the trailing inserter #3109

Closed
wants to merge 1 commit into from
Closed

Inserter: Fix misaligned tooltip for the trailing inserter #3109

wants to merge 1 commit into from

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Oct 23, 2017 •
edited
Loading

Description

I noticed that the tooltip opened for the trailing inserter is misaligned at the moment:

screen shot 2017-10-19 at 11 38 01

This PR tries to fix it.

How Has This Been Tested?

Manually:

  • Open Gutenberg editor.
  • Click inserter button on the very bottom of the post/page.

Screenshots (jpeg or gifs if applicable):

Before

screen shot 2017-10-19 at 11 38 01

screen shot 2017-10-23 at 10 59 43

After

screen shot 2017-10-23 at 11 01 00

screen shot 2017-10-23 at 11 01 16

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@gziolo gziolo added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended labels Oct 23, 2017
@gziolo gziolo self-assigned this Oct 23, 2017
@gziolo gziolo requested a review from jasmussen October 23, 2017 09:07
@jasmussen
Copy link
Contributor

Nice work, thanks for working on this. In testing this, I think I realized why this regression was introduced:

screen shot 2017-10-23 at 11 24 58

screen shot 2017-10-23 at 11 25 18

If we can move the bubble-connector 4px rightwards on only the two right side dropdowns, I think this is good to go 👍 👍

(I also do apologize, I think I'm the one who introduced these issues initially)

@jasmussen
Copy link
Contributor

Also, I think we should ship this regardless of what happens with #3078

@gziolo
Copy link
Member Author

gziolo commented Oct 23, 2017

Okey, I will take care of those dropdowns, too 👍

@gziolo
Copy link
Member Author

gziolo commented Dec 8, 2017

#3078 will soon make it obsolete. Closing this one.

@gziolo gziolo closed this Dec 8, 2017
@gziolo gziolo deleted the fix/inserter-misaligned-tooltip branch December 8, 2017 09:28
@gziolo gziolo mentioned this pull request Dec 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen Awaiting requested review from jasmussen

Assignees

@gziolo gziolo

Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @jasmussen