Save panel - decouple Site Entity items for individual saving. #30816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
requested review from
vindl,
jeyip,
mattwiebe,
Copons,
creativecoder,
david-szabo97 and
jameskoster
7 tasks
|
Size Change: +373 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
|
Looking good! The E2E test is failing and there is a conflicting file that needs to be resolved. After those, I'm happy to ✅ |
Yeah, I see thats happening but Im not quite sure what that is about yet. Handled the merge conflict and updated so will see how it goes now. |
|
It looks like the |
carolinan
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aims to solve #29462 (alternative to #30779) This PR explores decoupling the site entity's edits and modularizing them in the save panel, allowing for individual checkbox selection of each edited item:
Previously, any combination of these items would fall under the same checkbox with an obscure (actual site title) label and they all would have to be saved (or not saved) together:
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).