Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Kind attribute missing subtitle value in video text track #30040

Conversation

sunnyssr
Copy link
Contributor

Description

In video text track, kind attribute takes any value in Gutenberg editor.
When the block is rendered, it shows the selected kind attribute. But in case of subtitles, same doesn't happen. It doesn't show the kind attribute.

How has this been tested?

Screenshots

Before:
image
image

After:
image
image

Types of changes

fixes #26673

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

cc @annezazu @paaljoachim

@sunnyssr sunnyssr requested a review from ajitbohra as a code owner March 19, 2021 18:35
@gwwar gwwar self-requested a review March 19, 2021 20:56
Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sunnyssr this one tests well for me!

The one difference in behavior is that if this block switches it's default kind in the future, existing blocks won't use that default. I think this is fine, since most folks wouldn't expect that to change, if say they added a video track, published, and a future wp or plugin update changed their defaults.

cc @jorgefilipecosta in case I missed some other usecase.

Screen Shot 2021-03-22 at 10 08 26 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video text track: Kind attribute missing from block markup when value set to Subtitles
2 participants