Try: more accessible labels. #29659
Merged
Try: more accessible labels. #29659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Block] Social
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
gwwar
reviewed
Mar 11, 2021
aristath
requested changes
Mar 12, 2021
jasmussen
force-pushed
the
try/social-links-more-accessible-labels
branch
from
cd8e47e to
8b08364
Compare
Co-authored-by: Ari Stathopoulos <[email protected]>
Nice, that works well for me. Thank you! |
aristath
approved these changes
Mar 16, 2021
gziolo
reviewed
Mar 16, 2021
| $label = ( isset( $attributes['label'] ) ) ? $attributes['label'] : block_core_social_link_get_name( $service ); | ||
| $label = ( isset( $attributes['label'] ) ) ? $attributes['label'] : sprintf( | ||
| /* translators: %1$s: Social-network name. %2$s: URL. */ | ||
| __( '%1$s: %2$s', 'gutenberg' ), |
There was a problem hiding this comment.
Does it really need to be applied in the translation? It looks like sprintf is enough.
There was a problem hiding this comment.
If it's not in the translation, then how would an RTL language reverse it, or how would French add a space before the :? 🤔
There was a problem hiding this comment.
I see now it's only used with aria-label so it's going to be read by the assistive technology which is yet another set of challenges. No idea, how to approach it 🤷🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21840.
This PR adds the URL as an additional aria label suffix to social links.
This is a small improvement to the aria label for social links. Users can still add a more verbose label in the interface:
How has this been tested?
Checklist: