Multi entity save panel - remove dynamic copy. #29637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
requested review from
vindl,
jeyip,
mattwiebe,
Copons,
david-szabo97,
youknowriad and
jameskoster
|
Size Change: -1.28 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Mar 10, 2021
jameskoster
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For reasons listed in #29635 - this dynamic copy is problematic for i18n and no longer necessary given the new state of the save panel. Therefore, here we are moving the dynamic copy:
and replacing it with
Discussion on the copy to use is happening in the issue noted above.
How has this been tested?
Test the multi entity save panel in the site editor by making changes to one and/or various entities.
verify the new copy shows up and save flow works as expected.
Test this in the post editor as well by adding another entity to the post such as a template part.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: