Experiment: Temporary hack to render blocks in customizer #29365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Experimental
|
Size Change: +3.92 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
kevin940726
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
noisysocks
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
Nice work @kevin940726!
I see a few obvious issues, but nothing that I think should stop us merging this as this PR lets us iterate on the UI.
-
If you select a paragraph block at the bottom of the Customizer block editor, add a new paragraph block by pressing Enter, then type some text, it seems to create one new widget per keystroke.
-
Can't reorder or delete a block because the block toolbar disappears when you click on it.
-
Can't add a block because there's no inserter. See Blocks in Customizer: Implement slide-out inserter #29285.
-
Legacy Widget blocks don't load, as you say. Let's wait until Legacy Widget add support for widgets with attributes that can't be serialised into JSON #28902 before looking at this as the Legacy Widget block will need to be changed anyway.
| @@ -135,7 +135,7 @@ export default class SidebarAdapter { | |||
| }; | |||
| } | |||
|
|
|||
| addWidget( widget ) { | |||
| addWidget( widget, index ) { | |||
There was a problem hiding this comment.
Maybe default this to something e.g. index = 0?
There was a problem hiding this comment.
IMHO, this method should remain private, thus we don't need to assign defaults to make it easy to use. Instead, we should mark index as required explicitly to prevent us from introducing unexpected bugs 😅 .
packages/customize-widgets/src/components/sidebar-block-editor/use-sidebar-block-editor.js
Outdated
Show resolved
Hide resolved
packages/customize-widgets/src/components/sidebar-block-editor/use-sidebar-block-editor.js
Show resolved
Hide resolved
kevin940726
deleted the
try/temporary-fix-to-make-blocks-appear-in-customizer
branch
This was referenced Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #29283.
Add a temporary hack to render blocks in widgets customizer.
Editing blocks works, but adding a new block currently doesn't work as expected. Seems like adding a block in the original customizer already doesn't work?
Also the legacy widgets still don't render correctly.
How has this been tested?
Screenshots
Kapture.2021-02-26.at.15.56.25.mp4
Types of changes
New feature
Checklist: