Blocks: Ensure that metadata registered on the server for core block is preserved on the client #29213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Feature] Block API
8 tasks
gziolo
commented
Feb 22, 2021
|
Size Change: +18 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
gziolo
changed the title
gziolo
added a commit
that referenced
this pull request
Feb 23, 2021
…is preserved on the client (#29213) * export metadata, temporary placeholder to not override server values * Add e2e test that ensure that filtered metadata is propagated to the client * Fix issues raised by PHP linter Co-authored-by: Kerry Liu <[email protected]>
|
We need to revert this one @glendaviesnz found that this is wrapping blocks in additional divs |
talldan
removed
the
Backport to WP 6.8 Beta/RC
|
Removing the backport label as there's a revert for this PR - #29279 |
|
This PR is causing all blocks to wrapped in a |
|
Yes, it's because I checked all |
|
Can we add an automated test (e2e, snapshot, or otherwise) to guard against this? What would be the most reliable/generalized/minimal way of covering this? #bernieTestNag |
|
@ockham I'll make a simple test |
7 tasks
7 tasks
noisysocks
pushed a commit
that referenced
this pull request
Mar 1, 2021
…is preserved on the client (#29213) * export metadata, temporary placeholder to not override server values * Add e2e test that ensure that filtered metadata is propagated to the client * Fix issues raised by PHP linter Co-authored-by: Kerry Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #29095.
Alternative to #28829.
Props to @gwwar for the proposed solution.
This PR resolves the issue where metadata registered on the server from
block.jsonwould get overridden by the same data registered again on the client. The fix proposed ensures that for all blocks that have some metadata present, we skip all other attempts to pass the same metadata.unstable__bootstrapServerSideBlockDefinitionswas never meant to stay for so long, but here we are. It isn't part of public API so we shouldn't be worried about backward compatibility that much.It's a blocker for #29095.
It also was caught by @audrasjb when compiling the dev note for new filters added for
register_block_type_from_metadata. I included e2e tests that ensure that one of the new filters is properly propagated to the client.How has this been tested?
There is a new e2e test added that ensures that the updated logic works correctly:
Types of changes
Bug fix (non-breaking change which fixes an issue). Should be backported to WordPress 5.7. /cc @noisysocks.
Checklist: