Site Editor: Offset insertion point in iframe #28630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
requested review from
mattwiebe,
youknowriad,
vindl,
Copons,
jeyip and
Addison-Stavlo
david-szabo97
commented
Feb 1, 2021
| @@ -23,6 +23,24 @@ import { isRTL } from '@wordpress/i18n'; | |||
| import Inserter from '../inserter'; | |||
| import { getBlockDOMNode } from '../../utils/dom'; | |||
|
|
|||
| function offsetIframe( rect, ownerDocument ) { | |||
There was a problem hiding this comment.
This functions comes from
Is there a good package to host this function so we can use it in both components and block-editor package?
There was a problem hiding this comment.
I'm not sure if there's an clear candidate but maybe the @wordpress/dom package could be a fit.
There was a problem hiding this comment.
I took a brief look at Gutenberg packages and agree that @wordpress/dom might be the right place
|
Size Change: +810 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
mattwiebe
approved these changes
Feb 1, 2021
david-szabo97
force-pushed
the
fix/site-editor-inserter-point-vertical-position
branch
from
cbe933e to
390a281
Compare
TestingBehavior
Browsers
It looks like the site editor isn't loading again in IE11. It isn't caused by this PR because I can confirm the same issue on the master branch. I'm reopening #28249
|
I agree -- I think it's fine to move forward with this for now, but could we create an issue and/or leave a comment? We could explain the |
|
Would it be possible to write unit specs for this? |
jeyip
reviewed
Feb 5, 2021
david-szabo97
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
youknowriad
reviewed
Feb 8, 2021
packages/dom/src/dom.js
Outdated
| * | ||
| * @return {DOMRect} offsetted bounds | ||
| */ | ||
| export function offsetIframe( rect, ownerDocument ) { |
There was a problem hiding this comment.
now that it's a public API, maybe we should find a better name? @ellatrix any thoughts on this?
There was a problem hiding this comment.
🤔 How about: offsetBoundsByOwnerFrame, offsetRectByOwnerFrame, frameToScreenPosition, frameToScreenBounds ?
There was a problem hiding this comment.
Why does it need to be public? Can we not offset the iframe in the popover after we get the anchor rect? Why are we using getAnchorRect in the first place? That's supposed to be an old API to be deprecated at some point.
There was a problem hiding this comment.
@ellatrix Moved offsetIframe back into the popover package. This time into the utils.
jeyip
reviewed
Feb 8, 2021
jeyip
reviewed
Feb 8, 2021
jeyip
reviewed
Feb 8, 2021
|
When did this regress? When I merged the iframe PR, it worked correctly. Would be great to know what changed broke it. |
I don't think it was a regress. Popover works fine and offsets its position by the iframe position. But |
|
The custom logic to calculate position is new and I added it in #27860 |
|
Moved |
|
@youknowriad can we include this in 10.0? It looks pretty broken now. |
youknowriad
added
[Type] Bug
|
yes, sounds good to me. |
david-szabo97
deleted the
fix/site-editor-inserter-point-vertical-position
branch
youknowriad
pushed a commit
that referenced
this pull request
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28457 #28885
We moved the editor content into an iframe. It already handles offsetting the popover if a ref is passed. But insertion point calculates the position on its own which doesn't take the iframe offset into account. This change offsets the insertion point in the iframe so it's placed at the right position.
How has this been tested?
Paragraphblock, fill it up with some random textColumnsblock, choose 50 / 50ColumnblockScreenshots
Before
Screen.Recording.2021-01-25.at.10.51.51.mov
After
Screen.Recording.2021-02-01.at.13.44.44.mov
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: