-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor code smell in template part previews. #26949
Fix minor code smell in template part previews. #26949
Conversation
Size Change: +707 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
Template previews show up as expected, but since we're fixing code smells, how about also updating the default export from gutenberg/packages/block-library/src/template-part/edit/selection/template-part-previews.js Line 202 in 1d21b92
Unrelated: I've noticed that if I select a part that is already used in the same template (e.g. template has |
Good call. I didn't even notice that. Done ✅
Yeah... some block sync issues - trying to be addressed in #24180 - Noah laid out a more detailed explanation in some comments around here #24180 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I select a part that is already used in the same template (e.g. template has header and footer, and I convert footer into header), all parts break.
Yeah... some block sync issues - trying to be addressed in #24180 - Noah laid out a more detailed explanation in some comments around here #24180 (comment)
Nice! Great to know it is tracked and being worked on. ✨
Description
I made a code smell months back, it was bugging me. There should be no change in functionality.
![smell-bad](https://user-images.githubusercontent.com/28742426/99017483-0a7ed000-2526-11eb-8f18-c9aed2ce1f86.jpg)
How has this been tested?
Test template part previews through the template part placeholder block or the dropdown in the template part block's toolbar. Verify the same templates appear.
Screenshots
Types of changes
Checklist: