Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor code smell in template part previews. #26949

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

Addison-Stavlo
Copy link
Contributor

Description

I made a code smell months back, it was bugging me. There should be no change in functionality.
smell-bad

How has this been tested?

Test template part previews through the template part placeholder block or the dropdown in the template part block's toolbar. Verify the same templates appear.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions
Copy link

github-actions bot commented Nov 13, 2020

Size Change: +707 B (0%)

Total Size: 1.19 MB

Filename Size Change
build/block-editor/index.js 133 kB +345 B (0%)
build/block-editor/style-rtl.css 11.3 kB +114 B (1%)
build/block-editor/style.css 11.2 kB +111 B (0%)
build/block-library/index.js 147 kB +17 B (0%)
build/blocks/index.js 48 kB +7 B (0%)
build/components/index.js 171 kB +91 B (0%)
build/components/style-rtl.css 15.3 kB +23 B (0%)
build/components/style.css 15.3 kB +24 B (0%)
build/edit-site/index.js 23.2 kB -92 B (0%)
build/edit-site/style-rtl.css 3.98 kB +24 B (0%)
build/edit-site/style.css 3.98 kB +24 B (0%)
build/notices/index.js 1.79 kB +19 B (1%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.77 kB 0 B
build/api-fetch/index.js 3.42 kB 0 B
build/autop/index.js 2.84 kB 0 B
build/blob/index.js 664 B 0 B
build/block-directory/index.js 8.71 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-library/editor-rtl.css 8.91 kB 0 B
build/block-library/editor.css 8.91 kB 0 B
build/block-library/style-rtl.css 8.1 kB 0 B
build/block-library/style.css 8.1 kB 0 B
build/block-library/theme-rtl.css 792 B 0 B
build/block-library/theme.css 793 B 0 B
build/block-serialization-default-parser/index.js 1.87 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/compose/index.js 9.9 kB 0 B
build/core-data/index.js 14.8 kB 0 B
build/data-controls/index.js 821 B 0 B
build/data/index.js 8.74 kB 0 B
build/date/index.js 11.2 kB 0 B
build/deprecated/index.js 768 B 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.92 kB 0 B
build/edit-navigation/index.js 11.1 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.43 kB 0 B
build/edit-post/style.css 6.42 kB 0 B
build/edit-widgets/index.js 26.3 kB 0 B
build/edit-widgets/style-rtl.css 3.16 kB 0 B
build/edit-widgets/style.css 3.16 kB 0 B
build/editor/editor-styles-rtl.css 476 B 0 B
build/editor/editor-styles.css 478 B 0 B
build/editor/index.js 42.5 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/element/index.js 4.62 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 6.86 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.16 kB 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 713 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.1 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 790 B 0 B
build/redux-routine/index.js 2.83 kB 0 B
build/reusable-blocks/index.js 3.05 kB 0 B
build/rich-text/index.js 13.3 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@gziolo gziolo added [Block] Template Part Affects the Template Parts Block [Feature] Full Site Editing labels Nov 13, 2020
@Copons
Copy link
Contributor

Copons commented Nov 13, 2020

Template previews show up as expected, but since we're fixing code smells, how about also updating the default export from TemplateParts to TemplatePartPreviews? 🙂


Unrelated: I've noticed that if I select a part that is already used in the same template (e.g. template has header and footer, and I convert footer into header), all parts break. 🤔

Nov-13-2020 11-08-40

@Addison-Stavlo
Copy link
Contributor Author

Template previews show up as expected, but since we're fixing code smells, how about also updating the default export from TemplateParts to TemplatePartPreviews? 🙂

Good call. I didn't even notice that. Done ✅

I select a part that is already used in the same template (e.g. template has header and footer, and I convert footer into header), all parts break.

Yeah... some block sync issues - trying to be addressed in #24180 - Noah laid out a more detailed explanation in some comments around here #24180 (comment)

Copy link
Contributor

@Copons Copons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I select a part that is already used in the same template (e.g. template has header and footer, and I convert footer into header), all parts break.

Yeah... some block sync issues - trying to be addressed in #24180 - Noah laid out a more detailed explanation in some comments around here #24180 (comment)

Nice! Great to know it is tracked and being worked on. ✨

@Addison-Stavlo Addison-Stavlo merged commit 132a69f into master Nov 13, 2020
@Addison-Stavlo Addison-Stavlo deleted the fix/minor-code-smell-template-part-previews branch November 13, 2020 15:00
@github-actions github-actions bot added this to the Gutenberg 9.4 milestone Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants