Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run assign fixed issues and first time contributor label tasks for PRs from forks #26876

Merged
merged 6 commits into from
Nov 11, 2020

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Nov 11, 2020

Description

Fixes #17324

Github actions for a while had a limitation that certain actions could not be taken on PRs from forks as the access token provided in the action was read only.

As kindly pointed out #17324 (comment), github has now introduced a new pull_request_target event that receives a full read/write access token. This action is run against the base of the PR so has no security issues from commits that the PR introduces.

In this PR I've:

  • Split out a separate 'firstTimeContributorLabel' task that runs on the pull_request_target event (when a pull request is opened) and labels PRs from first time contributors
  • Removed the labelling we already did when first time contributor PRs are merged as that's now redundant. The existing task has been renamed from 'firstTimeContributor' to 'firstTimeContributorAccountLink' (it posts a message reminding users to link their github account to their WordPress org profile). Seems sensible to keep this the same.
  • Also run the 'assignFixedIssues' task on pull_request_target, previously it didn't run on PRs from forks.

I think we may also want to consider adding a welcome message for first time contributors, but I've focused on getting things working to start with.

How has this been tested?

Unit tests

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@talldan talldan added the [Package] Project management automation /packages/project-management-automation label Nov 11, 2020
@talldan talldan self-assigned this Nov 11, 2020
@talldan talldan changed the title Update/first time contributor action Run assign fixed issues and first time contributor label tasks for PRs from forks Nov 11, 2020
@github-actions
Copy link

github-actions bot commented Nov 11, 2020

Size Change: 0 B

Total Size: 1.19 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.77 kB 0 B
build/api-fetch/index.js 3.42 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 664 B 0 B
build/block-directory/index.js 8.71 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 133 kB 0 B
build/block-editor/style-rtl.css 11.2 kB 0 B
build/block-editor/style.css 11.1 kB 0 B
build/block-library/editor-rtl.css 8.91 kB 0 B
build/block-library/editor.css 8.91 kB 0 B
build/block-library/index.js 147 kB 0 B
build/block-library/style-rtl.css 8.1 kB 0 B
build/block-library/style.css 8.1 kB 0 B
build/block-library/theme-rtl.css 792 B 0 B
build/block-library/theme.css 793 B 0 B
build/block-serialization-default-parser/index.js 1.87 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/blocks/index.js 48 kB 0 B
build/components/index.js 171 kB 0 B
build/components/style-rtl.css 15.3 kB 0 B
build/components/style.css 15.3 kB 0 B
build/compose/index.js 9.87 kB 0 B
build/core-data/index.js 14.8 kB 0 B
build/data-controls/index.js 821 B 0 B
build/data/index.js 8.73 kB 0 B
build/date/index.js 11.2 kB 0 B
build/deprecated/index.js 768 B 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.46 kB 0 B
build/edit-navigation/index.js 11.1 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.43 kB 0 B
build/edit-post/style.css 6.42 kB 0 B
build/edit-site/index.js 22.6 kB 0 B
build/edit-site/style-rtl.css 3.95 kB 0 B
build/edit-site/style.css 3.95 kB 0 B
build/edit-widgets/index.js 26.3 kB 0 B
build/edit-widgets/style-rtl.css 3.16 kB 0 B
build/edit-widgets/style.css 3.16 kB 0 B
build/editor/editor-styles-rtl.css 476 B 0 B
build/editor/editor-styles.css 478 B 0 B
build/editor/index.js 42.5 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/element/index.js 4.62 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 6.86 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.16 kB 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 713 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.1 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.31 kB 0 B
build/notices/index.js 1.77 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 790 B 0 B
build/redux-routine/index.js 2.83 kB 0 B
build/reusable-blocks/index.js 3.05 kB 0 B
build/rich-text/index.js 13.4 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.83 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@talldan talldan requested a review from noisysocks November 11, 2020 05:08
@talldan
Copy link
Contributor Author

talldan commented Nov 11, 2020

I'm not completely convinced this works. I would've expected to see a pull_request_target event come through:
https://github.com/WordPress/gutenberg/actions?query=event%3Apull_request_target

but there are none. Could be something to merge and try?

Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Could be something to merge and try?

Yeah, maybe just try this and see what's wrong?

@talldan
Copy link
Contributor Author

talldan commented Nov 11, 2020

Lets give it a go!

@talldan talldan merged commit 998965a into master Nov 11, 2020
@talldan talldan deleted the update/first-time-contributor-action branch November 11, 2020 07:58
@github-actions github-actions bot added this to the Gutenberg 9.4 milestone Nov 11, 2020
@talldan
Copy link
Contributor Author

talldan commented Nov 11, 2020

Cool, an event came through here on my next PR:
https://github.com/WordPress/gutenberg/actions?query=event%3Apull_request_target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Project management automation /packages/project-management-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github actions don't work for pull requests created that involve a fork.
2 participants