-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run assign fixed issues and first time contributor label tasks for PRs from forks #26876
Conversation
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
I'm not completely convinced this works. I would've expected to see a but there are none. Could be something to merge and try? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Could be something to merge and try?
Yeah, maybe just try this and see what's wrong?
Lets give it a go! |
Cool, an event came through here on my next PR: |
Description
Fixes #17324
Github actions for a while had a limitation that certain actions could not be taken on PRs from forks as the access token provided in the action was read only.
As kindly pointed out #17324 (comment), github has now introduced a new
pull_request_target
event that receives a full read/write access token. This action is run against the base of the PR so has no security issues from commits that the PR introduces.In this PR I've:
I think we may also want to consider adding a welcome message for first time contributors, but I've focused on getting things working to start with.
How has this been tested?
Unit tests
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: