Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus return: make document.activeElement relative to ref #26814

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Nov 9, 2020

Description

There's no need to depend on document.activeElement on the consumer side. For the focussed node at the time of mount, we can look at the focus history that is provided. To ensure history, we can initialise the provider's history with document.activeElement.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ellatrix ellatrix added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 9, 2020
@github-actions
Copy link

github-actions bot commented Nov 9, 2020

Size Change: -1.62 kB (0%)

Total Size: 1.21 MB

Filename Size Change
build/annotations/index.js 3.77 kB -5 B (0%)
build/api-fetch/index.js 3.42 kB -28 B (0%)
build/autop/index.js 2.83 kB -3 B (0%)
build/block-directory/index.js 8.71 kB -10 B (0%)
build/block-editor/index.js 133 kB -117 B (0%)
build/block-library/index.js 146 kB -330 B (0%)
build/block-serialization-default-parser/index.js 1.87 kB -8 B (0%)
build/block-serialization-spec-parser/index.js 3.06 kB -41 B (1%)
build/blocks/index.js 48 kB -164 B (0%)
build/components/index.js 171 kB -309 B (0%)
build/compose/index.js 9.87 kB +62 B (0%)
build/core-data/index.js 12.5 kB -34 B (0%)
build/data/index.js 8.77 kB -27 B (0%)
build/date/index.js 31.8 kB -13 B (0%)
build/dom/index.js 4.45 kB -2 B (0%)
build/edit-navigation/index.js 11.1 kB -46 B (0%)
build/edit-post/index.js 305 kB -98 B (0%)
build/edit-site/index.js 22.5 kB -13 B (0%)
build/edit-widgets/index.js 26.2 kB -121 B (0%)
build/editor/index.js 42.6 kB -163 B (0%)
build/element/index.js 4.62 kB -27 B (0%)
build/format-library/index.js 6.62 kB -15 B (0%)
build/hooks/index.js 2.16 kB -3 B (0%)
build/keycodes/index.js 1.94 kB -1 B
build/list-reusable-blocks/index.js 3.1 kB -6 B (0%)
build/media-utils/index.js 5.32 kB -24 B (0%)
build/notices/index.js 1.77 kB -16 B (0%)
build/nux/index.js 3.4 kB -19 B (0%)
build/plugins/index.js 2.56 kB +2 B (0%)
build/redux-routine/index.js 2.84 kB -9 B (0%)
build/reusable-blocks/index.js 3.05 kB -2 B (0%)
build/rich-text/index.js 13.4 kB -23 B (0%)
build/server-side-render/index.js 2.77 kB -3 B (0%)
build/viewport/index.js 1.84 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/blob/index.js 665 B 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/style-rtl.css 11.2 kB 0 B
build/block-editor/style.css 11.2 kB 0 B
build/block-library/editor-rtl.css 8.96 kB 0 B
build/block-library/editor.css 8.96 kB 0 B
build/block-library/style-rtl.css 8.05 kB 0 B
build/block-library/style.css 8.05 kB 0 B
build/block-library/theme-rtl.css 792 B 0 B
build/block-library/theme.css 793 B 0 B
build/components/style-rtl.css 15.3 kB 0 B
build/components/style.css 15.3 kB 0 B
build/data-controls/index.js 771 B 0 B
build/deprecated/index.js 769 B 0 B
build/dom-ready/index.js 571 B 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/style-rtl.css 6.41 kB 0 B
build/edit-post/style.css 6.39 kB 0 B
build/edit-site/style-rtl.css 3.91 kB 0 B
build/edit-site/style.css 3.91 kB 0 B
build/edit-widgets/style-rtl.css 3.12 kB 0 B
build/edit-widgets/style.css 3.12 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 712 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 791 B 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@ellatrix ellatrix force-pushed the try/focus-return-hooks branch from ec289de to 9459cb1 Compare November 9, 2020 09:49
@ellatrix ellatrix changed the title Focus return: hooks + relative document Focus return: relative document.activeElement Nov 9, 2020
@ellatrix ellatrix force-pushed the try/focus-return-hooks branch from 9459cb1 to ffb9607 Compare November 9, 2020 11:00
@ellatrix ellatrix changed the title Focus return: relative document.activeElement Focus return: avoid document.activeElement Nov 9, 2020
@ellatrix ellatrix changed the title Focus return: avoid document.activeElement Focus return: make document.activeElement relative to ref Nov 9, 2020
@ellatrix ellatrix merged commit b21a82d into master Nov 9, 2020
@ellatrix ellatrix deleted the try/focus-return-hooks branch November 9, 2020 14:18
@github-actions github-actions bot added this to the Gutenberg 9.4 milestone Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant