Fix the RTL test snapshots #26350
Closed
Fix the RTL test snapshots #26350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Automated Testing
youknowriad
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
I'm not sure why this happened. I suspect there's some context in https://github.com/WordPress/gutenberg/pull/22213/files#r443408438. How can I best help here? Best I can tell, this PR is fine, and I'm happy to approve. |
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
|
yeah, it's very weird that "padding" impacts RTL keyboard navigation, I don't expect that because we're using "left/right" arrows and not "top/down". Maybe @ellatrix has ideas here. |
|
Sorry, forgot about this one. I'll look into it. |
|
When I run this locally, I get the snapshots that you want to merge here. How do I reproduce failing tests when checking out this PR? |
|
@ellatrix I don't know, I think for me it's inconsistent, so maybe CPU throttling? |
|
What theme is used on Travis? |
|
@ellatrix 2021 |
|
Fixed in #26508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, this PR introduced new snapshots for the RTL tests #22213
The problem is, these snapshots are wrong. that's not what we expect there.
I expect this PR is going to break the RTL tests but we should try to find why the result doesn't match the snapshot and not just use broken snapshots.