-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Schedule: highlight posts as calendar events #25425
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +288 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
9 tasks
Closing it in favor of #29716 |
#29716 is a fresh attempt to tackle this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Status] In Progress
Tracking issues with work in progress
[Type] Experimental
Experimental feature or API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to highlight events into the post schedule, picking data up the site posts filtering by status (
publish
andfuture
).NOTE: This main purpose of this implementation is to show certain weaknesses of the current date component.
fixes #13713
Issues
Lack of
onMonthViewChange
or similarWe want to know when the month view changes. It could be ideal to fetch the posts by month. I've created an
onMonthChange
callback property for the<DatePicker >
component but, to be honest, it doesn't sound good to me because this callback is triggered byonNextMonthClick
andonPrevMonthClick
.Lack of month view
We'd like to set a different month view, not necessarily tied to the selected date. Now, AFAIK, it isn't possible since every time that the component is mounted, it makes focus on the current date.
It means, and it's an issue that you could confirm on this PR, every time that the app gets and propagates events (site post events), it triggers a new rendering process, and the
react-dates
focuses to the current date month. If the month before to rendering was different, it will change it :-(Also, the current implementation seems to be a little bit hacky, based on these comments:
link
link
How has this been tested?
Immediately
as default)Screenshots
Types of changes
Checklist: