Build: Use .min.js suffix for bundled JavaScript
#23926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1.02 MB (89%) 🏆 Total Size: 1.14 MB
ℹ️ View Unchanged
|
|
The size bot seems to be confused by the renames. For some reason the "new" (.min.js) packages don't offset the "removed" (.js) packages. The min versions do appear if you expand the "View Unchanged" section. |
sirreal
added
[Type] Code Quality
I'd love thoughts from @WordPress/gutenberg-core about whether this is an acceptable tradeoff. |
I did wonder if folks use the presence of So, ya I think it's an acceptable tradeoff. I'm assuming none of this work impacts the build process when things land in WP core (and that's a separate build process)? |
Yes, I believe that's a separate process handled here: https://github.com/WordPress/wordpress-develop/blob/b00172339467889b736cf0a8d0a7bc5a502b1158/tools/webpack/packages.js |
|
Looks good to me 👍 |
|
Thanks, everyone! |
ellatrix
pushed a commit
that referenced
this pull request
Jul 28, 2020
ellatrix
pushed a commit
that referenced
this pull request
Jul 28, 2020
ellatrix
added a commit
that referenced
this pull request
Jul 28, 2020
* Revert "Build: Use .min.js extension for bundled JavaScript (#23926)" (#24239) This reverts commit 40c6c8f. * Remove deprecated blockType.context support (#24155) Co-authored-by: Jon Surrell <[email protected]> Co-authored-by: Riad Benguella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The webpack-bundled packages intended for consumption via WordPress scripts in
build/are shipped with the Gutenberg plugin as minified sources.Contrary to WordPress convention, these minified sources use the
.jsextension rather than.min.js.Use the
.min.jsextension for bundled sources.Note:
The
.min.jsextension is hard-coded in a few places. This is optimized for the most common use case — when the scripts are used as part of the Gutenberg plugin.This is not accurate in development (
npm run dev) where the scripts are not minified. I consider this to be an acceptable tradeoff. Developers are unlikely to be confused by the.min.jsextension containing readable source.How has this been tested?
The Gutenberg plugin enqueues
.min.jsfrombuildand their dependencies correctly.Build (
npm run build:plugin-zip) and install the plugin on a site. The editor works correctly.Types of changes
Internal.
Checklist: